From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 1/7] xen: vNUMA support for PV guests Date: Tue, 19 Nov 2013 08:41:10 +0100 Message-ID: <1384846870.19880.17.camel@Abyss> References: <1384806262-12532-1-git-send-email-ufimtseva@gmail.com> <1384806262-12532-2-git-send-email-ufimtseva@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6793748377246003702==" Return-path: In-Reply-To: <1384806262-12532-2-git-send-email-ufimtseva@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Elena Ufimtseva Cc: keir@xen.org, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, msw@linux.com, lccycc123@gmail.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org --===============6793748377246003702== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-qWc2QHaaXjOi5VxE8Vf1" --=-qWc2QHaaXjOi5VxE8Vf1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On lun, 2013-11-18 at 15:24 -0500, Elena Ufimtseva wrote: > Signed-off-by: Elena Ufimtseva > diff --git a/xen/common/domctl.c b/xen/common/domctl.c > index 904d27b..af6ae9b 100644 > @@ -889,6 +890,84 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) = u_domctl) > } > break; > =20 > + case XEN_DOMCTL_setvnumainfo: > + { > + unsigned int dist_size, nr_vnodes; > + =20 > + ret =3D -EINVAL; > + =20 > + /*=20 > + * If number of vnodes was set before, > + * dont initilize it again. > + */ > + //ASSERT(d->vnuma.nr_vnodes > 0); > Kill this? :-P Apart from this, most of my comments to previous round have been addressed, but I think some of the ones Jan provided haven't. Elena, can you double check? http://bugs.xenproject.org/xen/mid/%3C5285EE480200007800103692@nat28.tlf.no= vell.com%3E > diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h > index a057069..77853e8 100644 > --- a/xen/include/xen/domain.h > +++ b/xen/include/xen/domain.h > @@ -89,4 +89,13 @@ extern unsigned int xen_processor_pmbits; > =20 > extern bool_t opt_dom0_vcpus_pin; > =20 > +struct vnuma_info { > + unsigned int nr_vnodes; > + unsigned int pad; > + unsigned int *vdistance; > + unsigned int *vcpu_to_vnode; > + unsigned int *vnode_to_pnode; > + struct vmemrange *vmemrange; > +}; > + > And one last thing. Sorry if it's me not remembering, but what's 'pad' above useful for? Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-qWc2QHaaXjOi5VxE8Vf1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKLFhYACgkQk4XaBE3IOsRixQCeJDgXBTirs9FenkP+WAYJJUIk nPkAoJdQZGuyeqb+UCGmtfrSjb7iCe1N =mS9g -----END PGP SIGNATURE----- --=-qWc2QHaaXjOi5VxE8Vf1-- --===============6793748377246003702== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6793748377246003702==--