All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Nic Bellinger <nab@linux-iscsi.org>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
	Hannes Reinecke <hare@suse.de>
Subject: [PATCH 04/18] target_core_alua: Store supported ALUA states
Date: Tue, 19 Nov 2013 09:07:49 +0100	[thread overview]
Message-ID: <1384848483-3771-5-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1384848483-3771-1-git-send-email-hare@suse.de>

The supported ALUA states might be different for individual
devices, so store it in a separate field.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/target/target_core_alua.c | 14 ++++++++------
 drivers/target/target_core_alua.h | 11 +++++++++++
 include/target/target_core_base.h |  1 +
 3 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/drivers/target/target_core_alua.c b/drivers/target/target_core_alua.c
index 08e41e3..a16115e 100644
--- a/drivers/target/target_core_alua.c
+++ b/drivers/target/target_core_alua.c
@@ -117,12 +117,7 @@ target_emulate_report_target_port_groups(struct se_cmd *cmd)
 		/*
 		 * Set supported ASYMMETRIC ACCESS State bits
 		 */
-		buf[off] = 0x80; /* T_SUP */
-		buf[off] |= 0x40; /* O_SUP */
-		buf[off] |= 0x8; /* U_SUP */
-		buf[off] |= 0x4; /* S_SUP */
-		buf[off] |= 0x2; /* AN_SUP */
-		buf[off++] |= 0x1; /* AO_SUP */
+		buf[off++] |= tg_pt_gp->tg_pt_gp_alua_supported_states;
 		/*
 		 * TARGET PORT GROUP
 		 */
@@ -1367,6 +1362,13 @@ struct t10_alua_tg_pt_gp *core_alua_allocate_tg_pt_gp(struct se_device *dev,
 	tg_pt_gp->tg_pt_gp_trans_delay_msecs = ALUA_DEFAULT_TRANS_DELAY_MSECS;
 	tg_pt_gp->tg_pt_gp_implicit_trans_secs = ALUA_DEFAULT_IMPLICIT_TRANS_SECS;
 
+	/*
+	 * Enable all supported states
+	 */
+	tg_pt_gp->tg_pt_gp_alua_supported_states =
+	    ALUA_T_SUP | ALUA_O_SUP | \
+	    ALUA_U_SUP | ALUA_S_SUP | ALUA_AN_SUP | ALUA_AO_SUP;
+
 	if (def_group) {
 		spin_lock(&dev->t10_alua.tg_pt_gps_lock);
 		tg_pt_gp->tg_pt_gp_id =
diff --git a/drivers/target/target_core_alua.h b/drivers/target/target_core_alua.h
index d6db78b..88e2e83 100644
--- a/drivers/target/target_core_alua.h
+++ b/drivers/target/target_core_alua.h
@@ -23,6 +23,17 @@
 #define ALUA_ACCESS_STATE_TRANSITION		0xf
 
 /*
+ * from spc4r36j section 6.37 Table 306
+ */
+#define ALUA_T_SUP		0x80
+#define ALUA_O_SUP		0x40
+#define ALUA_LBD_SUP		0x10
+#define ALUA_U_SUP		0x08
+#define ALUA_S_SUP		0x04
+#define ALUA_AN_SUP		0x02
+#define ALUA_AO_SUP		0x01
+
+/*
  * REPORT_TARGET_PORT_GROUP STATUS CODE
  *
  * from spc4r17 section 6.27 Table 246
diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h
index 658b356..a23785f 100644
--- a/include/target/target_core_base.h
+++ b/include/target/target_core_base.h
@@ -283,6 +283,7 @@ struct t10_alua_lu_gp_member {
 struct t10_alua_tg_pt_gp {
 	u16	tg_pt_gp_id;
 	int	tg_pt_gp_valid_id;
+	int	tg_pt_gp_alua_supported_states;
 	int	tg_pt_gp_alua_access_status;
 	int	tg_pt_gp_alua_access_type;
 	int	tg_pt_gp_nonop_delay_msecs;
-- 
1.7.12.4


  parent reply	other threads:[~2013-11-19  8:08 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19  8:07 [PATCHv2 00/18] ALUA update and Referrals support Hannes Reinecke
2013-11-19  8:07 ` [PATCH 01/18] target core: rename (ex,im)plict -> (ex,im)plicit Hannes Reinecke
2013-11-20 19:29   ` Nicholas A. Bellinger
2013-11-19  8:07 ` [PATCH 02/18] target_core_alua: spellcheck Hannes Reinecke
2013-11-20 19:30   ` Nicholas A. Bellinger
2013-11-19  8:07 ` [PATCH 03/18] target_core_alua: Rename ALUA_ACCESS_STATE_OPTIMIZED Hannes Reinecke
2013-11-20 19:30   ` Nicholas A. Bellinger
2013-11-19  8:07 ` Hannes Reinecke [this message]
2013-11-20 19:31   ` [PATCH 04/18] target_core_alua: Store supported ALUA states Nicholas A. Bellinger
2013-11-19  8:07 ` [PATCH 05/18] target_core_alua: Make supported states configurable Hannes Reinecke
2013-11-20 19:36   ` Nicholas A. Bellinger
2013-11-19  8:07 ` [PATCH 06/18] target_core_configfs: split up ALUA supported states Hannes Reinecke
2013-11-20 19:39   ` Nicholas A. Bellinger
2013-11-19  8:07 ` [PATCH 07/18] target_core_configfs: Verbose ALUA state display Hannes Reinecke
2013-11-19  8:07 ` [PATCH 08/18] target_core_configfs: Split up ALUA access type Hannes Reinecke
2013-11-19  8:07 ` [PATCH 09/18] target_core: Rename alua_access_type in alua_mgmt_type Hannes Reinecke
2013-11-19  8:07 ` [PATCH 10/18] target_core: Rename alua_access_status to alua_status_modification Hannes Reinecke
2013-11-19  8:07 ` [PATCH 11/18] target_core_alua: Validate ALUA state transition Hannes Reinecke
2013-11-19  8:07 ` [PATCH 12/18] target_core_alua: Allocate ALUA metadata on demand Hannes Reinecke
2013-11-19  8:07 ` [PATCH 13/18] target_core_alua: store old and pending ALUA state Hannes Reinecke
2013-11-19  8:07 ` [PATCH 14/18] target_core_alua: Use workqueue for ALUA transitioning Hannes Reinecke
2013-11-19  8:08 ` [PATCH 15/18] target_core: simplify scsi_name_len calculation Hannes Reinecke
2013-11-19  8:08 ` [PATCH 16/18] target_core_spc: Include target device descriptor in VPD page 83 Hannes Reinecke
2013-11-19  8:08 ` [PATCH 17/18] target_core_alua: Referrals infrastructure Hannes Reinecke
2013-11-19  8:08 ` [PATCH 18/18] target_core_alua: Referrals configfs integration Hannes Reinecke
2013-11-19 23:42 ` [PATCHv2 00/18] ALUA update and Referrals support Nicholas A. Bellinger
2013-11-20  0:06   ` Nicholas A. Bellinger
2013-11-20  7:44     ` Hannes Reinecke
2013-11-20 19:22       ` Nicholas A. Bellinger
2013-12-13 23:43         ` Nicholas A. Bellinger
2013-12-17  8:20           ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384848483-3771-5-git-send-email-hare@suse.de \
    --to=hare@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.