Re: [PATCH v3 02/14] libxl: sanitize error handling in libxl_get_max_{cpus, nodes}

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1816 bytes --]

On mar, 2013-11-19 at 12:24 +0000, George Dunlap wrote:
> On 11/18/2013 06:16 PM, Dario Faggioli wrote:
> > as well as both error handling and logging in libxl_cpu_bitmap_alloc
> > and libxl_node_bitmap_alloc.
> >
> > Now libxl_get_max_{cpus,nodes} either return a positive number, or
> > a libxl error code. Thanks to that, it is possible to fix loggig for
> > the two bitmap allocation functions, which now happens _inside_ the
> > functions themselves, and report what happens more accurately.
> >
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> 
> Reviewed-by: George Dunlap <george.dunlap@eu.citrix.com>
> 
Thanks.

> > diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c
> > index 682f874..2a51c9c 100644
> > --- a/tools/libxl/libxl_utils.c
> > +++ b/tools/libxl/libxl_utils.c
> > @@ -645,6 +645,46 @@ char *libxl_bitmap_to_hex_string(libxl_ctx *ctx, const libxl_bitmap *bitmap)
> >       return q;
> >   }
> >
> > +inline int libxl_cpu_bitmap_alloc(libxl_ctx *ctx,
> > +                                  libxl_bitmap *cpumap,
> > +                                  int max_cpus)
> 
> Stray 'inline'. :-)
> 
Wow... How did he manage to survive? I mean, I killed his 'static' buddy
but kept him? I guess I'm getting too old for late night hacking
sessions! :-P

Anyway, let's see how the rest of the review goes. If I have to resend,
I will fix this. Otherwise I can just resend this patch, or do whatever
the maintainers/committers are most comfortable with.

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel