From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 5/7] libxl: vNUMA configuration parser Date: Tue, 19 Nov 2013 18:20:38 +0100 Message-ID: <1384881638.19880.146.camel@Abyss> References: <1384806262-12532-1-git-send-email-ufimtseva@gmail.com> <1384806262-12532-6-git-send-email-ufimtseva@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0255736056844787736==" Return-path: In-Reply-To: <1384806262-12532-6-git-send-email-ufimtseva@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Elena Ufimtseva Cc: keir@xen.org, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, msw@linux.com, lccycc123@gmail.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org --===============0255736056844787736== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-rSVuLMstJD7kmI0Qkw9M" --=-rSVuLMstJD7kmI0Qkw9M Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Just one thing (for now)... On lun, 2013-11-18 at 15:24 -0500, Elena Ufimtseva wrote: > Signed-off-by: Elena Ufimtseva > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > index 8690ec7..d7aa0b3 100644 > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > This is the only file you modify in the patch, so the patch itself is about _xl_, rather than _libxl_, isn't it? Please, make the subject consistent with that. It's a big patch (and it should be even bigger, as you'll see from my comments on patch 7/7) so, perhaps, consider splitting it up, e.g., by having one patch for each new config option introduced (if feasible and not too hard). Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-rSVuLMstJD7kmI0Qkw9M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKLneYACgkQk4XaBE3IOsSqWQCfYyq1mFf8OAqZsdg8OlvkPXzy 8usAn1l44q6WMj09Vj7MObRy1XpFqH2s =PCxe -----END PGP SIGNATURE----- --=-rSVuLMstJD7kmI0Qkw9M-- --===============0255736056844787736== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0255736056844787736==--