Re: [PATCH] backports: remove obsolete linux/bitops.h header

[Johannes Berg <johannes@sipsolutions.net>]

On Tue, 2013-11-19 at 23:51 +0100, Hauke Mehrtens wrote:
> On 11/18/2013 03:26 PM, Stefan Assmann wrote:
> > The header seems to be obsolete. Removing it and running devel/ckmake didn't
> > reveal any errors. Missing parts can always be re-added in the new
> > include_next fashion if necessary.
> > 
> > Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
> 
> Some of these functions are needed, because they are not provided by old
> kernel versions.

Overall the idea seems right though - we should have something like

#ifndef __BACKPORT_BITOPS_H
#define __BACKPORT_BITOPS_H
#include_next <linux/bitops.h>

#ifndef for_each_set_bit
#define for_each_set_bit(...) \
	...
#endif

#if kernel_version < 2.6.38
static inline __s32 sign_extend32(...) { ... }
#endif

etc.

#endif /* __BACKPORT_BITOPS_H */

I think.

johannes