All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Subject: [RFCv3 14/14] HACK: drm: allow FB's in drm_mode_object_find
Date: Wed, 20 Nov 2013 15:48:13 -0500	[thread overview]
Message-ID: <1384980493-25499-15-git-send-email-robdclark@gmail.com> (raw)
In-Reply-To: <1384980493-25499-1-git-send-email-robdclark@gmail.com>

Ugg.. we do actually want to permit FB's in atomic case, since FB will
be looked up like any other object property value.

Currently we do the FB refcnt'ing dance in atomic->commit(), and would
rather not have to special case FB's or collect an FB ref when we look
up the property.  Not sure if it is better to rework the atomic FB
refcnt'ing or loosen this restriction?
---
 drivers/gpu/drm/drm_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 8368ef5..f71f7af 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -405,7 +405,7 @@ struct drm_mode_object *drm_mode_object_find(struct drm_device *dev,
 
 	/* Framebuffers are reference counted and need their own lookup
 	 * function.*/
-	WARN_ON(type == DRM_MODE_OBJECT_FB);
+//	WARN_ON(type == DRM_MODE_OBJECT_FB);
 
 	mutex_lock(&dev->mode_config.idr_mutex);
 	obj = idr_find(&dev->mode_config.crtc_idr, id);
-- 
1.8.4.2

      parent reply	other threads:[~2013-11-20 20:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20 20:47 [RFCv3 00/14] Atomic/nuclear modeset/pageflip Rob Clark
2013-11-20 20:48 ` [RFCv3 01/14] drm: add atomic fxns Rob Clark
2013-11-20 20:48 ` [RFCv3 02/14] drm: convert crtc to ww_mutex Rob Clark
2013-11-21 14:11   ` Maarten Lankhorst
2013-11-21 15:12     ` Rob Clark
2013-11-20 20:48 ` [RFCv3 03/14] drm: add object property type Rob Clark
2013-11-20 20:48 ` [RFCv3 04/14] drm: add DRM_MODE_PROP_DYNAMIC property flag Rob Clark
2013-11-20 20:48 ` [RFCv3 05/14] drm: add DRM_MODE_PROP_SIGNED " Rob Clark
2013-11-20 20:48 ` [RFCv3 06/14] drm: helpers to find mode objects Rob Clark
2013-11-20 20:48 ` [RFCv3 07/14] drm: split propvals out and blob property support Rob Clark
2013-11-20 20:48 ` [RFCv3 08/14] drm: Allow drm_mode_object_find() to look up an object of any type Rob Clark
2013-11-20 20:48 ` [RFCv3 09/14] drm: Refactor object property check code Rob Clark
2013-11-20 20:48 ` [RFCv3 10/14] drm: convert plane to properties/state Rob Clark
2013-11-20 20:48 ` [RFCv3 11/14] drm: convert crtc " Rob Clark
2013-11-21 14:25   ` Maarten Lankhorst
2013-11-20 20:48 ` [RFCv3 12/14] drm: Atomic modeset ioctl Rob Clark
2013-11-22  8:35   ` Inki Dae
2013-11-22 12:34     ` Rob Clark
2013-11-20 20:48 ` [RFCv3 13/14] drm/msm: add atomic support Rob Clark
2013-11-20 20:48 ` Rob Clark [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384980493-25499-15-git-send-email-robdclark@gmail.com \
    --to=robdclark@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.