From: Dave Airlie <airlied@gmail.com>
To: dri-devel@lists.freedesktop.org
Subject: [PATCH] drm/sysfs: fix hotplug regression since lifetime changes
Date: Thu, 21 Nov 2013 11:51:04 +1000 [thread overview]
Message-ID: <1384998664-5680-1-git-send-email-airlied@gmail.com> (raw)
5bdebb183c9702a8c57a01dff09337be3de337a6 changed the lifetimes, but it
also meant we no longer set the device_type field properly, so the
hotplug events in userspace weren't fully formed enough for drivers to care.
Reported-by: Jesse Barnes <jbarnes@virtuosugeek.org>
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/drm_sysfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
index 1a35ea5..c6a3902 100644
--- a/drivers/gpu/drm/drm_sysfs.c
+++ b/drivers/gpu/drm/drm_sysfs.c
@@ -516,6 +516,7 @@ int drm_sysfs_device_add(struct drm_minor *minor)
DRM_ERROR("device create failed %ld\n", PTR_ERR(minor->kdev));
return PTR_ERR(minor->kdev);
}
+ minor->kdev->type = &drm_sysfs_device_minor;
return 0;
}
--
1.8.4.2
next reply other threads:[~2013-11-21 2:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 1:51 Dave Airlie [this message]
2013-11-21 9:22 ` [PATCH] drm/sysfs: fix hotplug regression since lifetime changes Daniel Vetter
2013-11-21 9:25 ` Dave Airlie
2013-11-21 9:49 ` David Herrmann
2013-11-21 9:58 ` Dave Airlie
2013-11-21 10:00 ` David Herrmann
2013-11-21 10:20 ` Daniel Vetter
2013-11-21 15:24 ` Greg KH
2013-11-21 15:40 ` David Herrmann
2013-11-21 15:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384998664-5680-1-git-send-email-airlied@gmail.com \
--to=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.