All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: corentincj@iksaif.net, Peter Lieven <pl@kamp.de>,
	hengqing.hu@gmail.com, anthony@codemonkey.ws
Subject: [Qemu-devel] [PATCHv2 6/6] ui/vnc: disable adaptive update calculations if not needed
Date: Thu, 21 Nov 2013 09:51:17 +0100	[thread overview]
Message-ID: <1385023877-26524-7-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1385023877-26524-1-git-send-email-pl@kamp.de>

Signed-off-by: Peter Lieven <pl@kamp.de>
---
 ui/vnc.c |    9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/ui/vnc.c b/ui/vnc.c
index 5134456..46a9428 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3169,7 +3169,9 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp)
             acl = 1;
 #endif
         } else if (strncmp(options, "lossy", 5) == 0) {
+#ifdef CONFIG_VNC_JPEG
             vs->lossy = true;
+#endif
         } else if (strncmp(options, "non-adaptive", 12) == 0) {
             vs->non_adaptive = true;
         } else if (strncmp(options, "share=", 6) == 0) {
@@ -3186,6 +3188,13 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp)
         }
     }
 
+    /* adaptive updates are only used with tight encoding and
+     * if lossy updates are enabled so we can disable all the
+     * calculations otherwise */
+    if (!vs->lossy) {
+        vs->non_adaptive = true;
+    }
+
 #ifdef CONFIG_VNC_TLS
     if (acl && x509 && vs->tls.x509verify) {
         if (!(vs->tls.acl = qemu_acl_init("vnc.x509dname"))) {
-- 
1.7.9.5

  parent reply	other threads:[~2013-11-21  8:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21  8:51 [Qemu-devel] [PATCHv2 0/6] ui/vnc: update optimizations Peter Lieven
2013-11-21  8:51 ` [Qemu-devel] [PATCHv2 1/6] ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro Peter Lieven
2013-11-21  8:51 ` [Qemu-devel] [PATCHv2 2/6] ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT Peter Lieven
2013-11-21  8:51 ` [Qemu-devel] [PATCHv2 3/6] ui/vnc: optimize dirty bitmap tracking Peter Lieven
2013-11-21 15:16   ` Eric Blake
2013-11-21  8:51 ` [Qemu-devel] [PATCHv2 4/6] ui/vnc: optimize clearing in find_and_clear_dirty_height() Peter Lieven
2013-11-21  8:51 ` [Qemu-devel] [PATCHv2 5/6] ui/vnc: optimize setting in vnc_dpy_update() Peter Lieven
2013-11-21  8:51 ` Peter Lieven [this message]
2013-12-04 17:56 ` [Qemu-devel] RESEND: [PATCHv2 0/6] ui/vnc: update optimizations Peter Lieven
2013-12-04 18:20   ` Stefan Weil
2013-12-04 21:04     ` Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385023877-26524-7-git-send-email-pl@kamp.de \
    --to=pl@kamp.de \
    --cc=anthony@codemonkey.ws \
    --cc=corentincj@iksaif.net \
    --cc=hengqing.hu@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.