From: Michael Ellerman <michael@ellerman.id.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
Liu Ping Fan <kernelfans@gmail.com>
Subject: Re: [PATCH 2/2] powerpc: mm: change pgtable index size for 64K page
Date: Fri, 22 Nov 2013 13:06:08 +1100 [thread overview]
Message-ID: <1385085968.26020.0.camel@concordia> (raw)
In-Reply-To: <1385077581.4882.30.camel@pasglop>
On Fri, 2013-11-22 at 10:46 +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2013-11-22 at 09:11 +1100, Paul Mackerras wrote:
> > On Thu, Nov 21, 2013 at 10:17:55AM +0800, Liu Ping Fan wrote:
> > > For 64K page, we waste half of the pte_t page. With this patch, after
> > > changing PGD_INDEX_SIZE from 12 to 11, PTE_INDEX_SIZE from 8 to 9,
> > > we can improve the usage of pte_t page and shrink the continuous phys
> > > size for pgd_t.
>
> Also you did you miss that we use the second half to store the
> per-subpage hash info when using 64k on top of HW 4k ?
Given the subtleties perhaps a nice big block comment is in order ? :)
cheers
next prev parent reply other threads:[~2013-11-22 2:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 2:17 [PATCH 1/2] powerpc: mm: use macro PGTABLE_EADDR_SIZE instead of digital Liu Ping Fan
2013-11-21 2:17 ` [PATCH 2/2] powerpc: mm: change pgtable index size for 64K page Liu Ping Fan
2013-11-21 22:11 ` Paul Mackerras
2013-11-21 23:46 ` Benjamin Herrenschmidt
2013-11-22 2:06 ` Michael Ellerman [this message]
2014-04-30 5:30 ` [PATCH 1/2] powerpc: mm: use macro PGTABLE_EADDR_SIZE instead of digital Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385085968.26020.0.camel@concordia \
--to=michael@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=kernelfans@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.