From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Yue Tao <Yue.Tao@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/5] file: avoid to handle special character
Date: Wed, 27 Nov 2013 12:02:05 +0000 [thread overview]
Message-ID: <1385553725.11246.24.camel@ted> (raw)
In-Reply-To: <1385538944-8585-1-git-send-email-Yue.Tao@windriver.com>
On Wed, 2013-11-27 at 15:55 +0800, Yue Tao wrote:
> From: Li Wang <li.wang@windriver.com>
>
> avoid to handle special character '@' in filename and directory.
>
> Signed-off-by: Li Wang <li.wang@windriver.com>
> ---
> .../file/file/avoid_handle_special_character.patch | 36 ++++++++++++++++++++
> meta/recipes-devtools/file/file_5.15.bb | 1 +
> 2 files changed, 37 insertions(+), 0 deletions(-)
> create mode 100644 meta/recipes-devtools/file/file/avoid_handle_special_character.patch
No patch header and do we support "@" in directory names for builds?
Doesn't this break '#' instead?
Cheers,
Richard
> diff --git a/meta/recipes-devtools/file/file/avoid_handle_special_character.patch b/meta/recipes-devtools/file/file/avoid_handle_special_character.patch
> new file mode 100644
> index 0000000..4be4ad0
> --- /dev/null
> +++ b/meta/recipes-devtools/file/file/avoid_handle_special_character.patch
> @@ -0,0 +1,36 @@
> +--- a/doc/Makefile.am
> ++++ b/doc/Makefile.am
> +@@ -12,21 +12,21 @@
> +
> + file.1: Makefile file.man
> + @rm -f $@
> +- sed -e s@__CSECTION__@1@g \
> +- -e s@__FSECTION__@${fsect}@g \
> +- -e s@__VERSION__@${VERSION}@g \
> +- -e s@__MAGIC__@${MAGIC}@g $(srcdir)/file.man > $@
> ++ sed -e s#__CSECTION__#1#g \
> ++ -e s#__FSECTION__#${fsect}#g \
> ++ -e s#__VERSION__#${VERSION}#g \
> ++ -e s#__MAGIC__#${MAGIC}#g $(srcdir)/file.man > $@
> +
> + magic.${fsect}: Makefile magic.man
> + @rm -f $@
> +- sed -e s@__CSECTION__@1@g \
> +- -e s@__FSECTION__@${fsect}@g \
> +- -e s@__VERSION__@${VERSION}@g \
> +- -e s@__MAGIC__@${MAGIC}@g $(srcdir)/magic.man > $@
> ++ sed -e s#__CSECTION__#1#g \
> ++ -e s#__FSECTION__#${fsect}#g \
> ++ -e s#__VERSION__#${VERSION}#g \
> ++ -e s#__MAGIC__#${MAGIC}#g $(srcdir)/magic.man > $@
> +
> + libmagic.3: Makefile libmagic.man
> + @rm -f $@
> +- sed -e s@__CSECTION__@1@g \
> +- -e s@__FSECTION__@${fsect}@g \
> +- -e s@__VERSION__@${VERSION}@g \
> +- -e s@__MAGIC__@${MAGIC}@g $(srcdir)/libmagic.man > $@
> ++ sed -e s#__CSECTION__#1#g \
> ++ -e s#__FSECTION__#${fsect}#g \
> ++ -e s#__VERSION__#${VERSION}#g \
> ++ -e s#__MAGIC__#${MAGIC}#g $(srcdir)/libmagic.man > $@
> diff --git a/meta/recipes-devtools/file/file_5.15.bb b/meta/recipes-devtools/file/file_5.15.bb
> index aecbbe5..0697838 100644
> --- a/meta/recipes-devtools/file/file_5.15.bb
> +++ b/meta/recipes-devtools/file/file_5.15.bb
> @@ -12,6 +12,7 @@ DEPENDS = "zlib file-native"
> DEPENDS_class-native = "zlib-native"
>
> SRC_URI = "ftp://ftp.astron.com/pub/file/file-${PV}.tar.gz \
> + file://avoid_handle_special_character.patch \
> file://dump \
> file://filesystems"
>
next prev parent reply other threads:[~2013-11-27 12:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 7:55 [PATCH 1/5] file: avoid to handle special character Yue Tao
2013-11-27 7:55 ` [PATCH 2/5] eglibc: add support for /etc/ld.so.conf.d/*.conf Yue Tao
2013-11-27 12:46 ` Phil Blundell
2013-11-27 13:50 ` Martin Jansa
2013-11-27 7:55 ` [PATCH 3/5] bind: add init.d/bind status command Yue Tao
2013-11-27 11:58 ` Richard Purdie
2013-11-27 7:55 ` [PATCH 4/5] cronie: fix init.d/crond status return value Yue Tao
2013-11-27 7:55 ` [PATCH 5/5] tcf-agent: add init.d/tcf-agent status command Yue Tao
2013-11-27 12:02 ` Richard Purdie [this message]
2013-11-27 12:40 ` [PATCH 1/5] file: avoid to handle special character Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385553725.11246.24.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=Yue.Tao@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.