Re: Xen-4.3 and -unstable regression from changeset "numa-sched: leave node-affinity alone if not in 'auto' mode"

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1061 bytes --]

On gio, 2013-11-28 at 12:31 +0000, Andrew Cooper wrote:
> Hello,
> 
Hi,

> I have recently positivly identified
> b54a623efbcf5bff25c55117add1b4427b4e2f1b as causing a boot failure.
> 
> Serial log is attached.  The crash is completely deterministic, and is
> from an IBM xSeries 3530 M4 server.
> 
> Given the crash and bad patch, I suspect it is more to do with the
> NUMA/memory layout than the specifics of the server.
> 
> Dario: Being your patch, do you have any ideas?
> 
Wow... Not out of the top of my head... Can you try (or tell me how to
do that on that box) the attached debug patch?

I know it's gross, but given where and how early the crash happens, it
shouldn't be too bad, and it would hopefully at least tell if
d->node_affinity contains garbage.

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.1.2: node_affinity.patch --]
[-- Type: text/x-patch, Size: 1085 bytes --]

diff --git a/xen/common/domain.c b/xen/common/domain.c
index 2cbc489..06b099f 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -348,6 +348,13 @@ struct domain *domain_create(
     return ERR_PTR(err);
 }
 
+static void nodeset_print(char *set, int size, const nodemask_t *mask) 
+{ 
+    *set++ = '['; 
+    set += nodelist_scnprintf(set, size-2, mask); 
+    *set++ = ']'; 
+    *set++ = '\0'; 
+}
 
 void domain_update_node_affinity(struct domain *d)
 {
@@ -357,6 +364,8 @@ void domain_update_node_affinity(struct domain *d)
     struct vcpu *v;
     unsigned int node;
 
+    char tmpstr[256];
+
     if ( !zalloc_cpumask_var(&cpumask) )
         return;
     if ( !alloc_cpumask_var(&online_affinity) )
@@ -394,6 +403,9 @@ void domain_update_node_affinity(struct domain *d)
 
     spin_unlock(&d->node_affinity_lock);
 
+    nodeset_print(tmpstr, sizeof(tmpstr), &d->node_affinity);
+    printk("--VCPU: %d, d->node_affinity: %s\n", v->vcpu_id, tmpstr);
+
     free_cpumask_var(online_affinity);
     free_cpumask_var(cpumask);
 }

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel