Re: [RFC][PATCH] Input: define keys for WWAN and SES

[Bastien Nocera <hadess@hadess.net>]

On Thu, 2013-11-28 at 15:06 +0100, Rafał Miłecki wrote:
> 2013/11/28 Bastien Nocera <hadess@hadess.net>:
> > On Thu, 2013-11-28 at 13:32 +0100, Rafał Miłecki wrote:
> >> I'm just not sure about possible scenarios. I imagined end-user
> >> pressing SES button router and SES button on a device and complaining
> >> it's not working (because of SES being interpreted as WPS).
> >>
> >> If you guys think we should just use WPS for the SES button, I'm OK with that.
> >
> > Isn't the fact that it returns WPS or SES an implementation detail?
> >
> > Is WPS vs. SES just a software choice, or a hardware one? If it's a
> > hardware one, you'd expect to have other ways to discover whether SES or
> > WPS was requested (because that's the one supported by the hardware). If
> > it's a software choice, then you'd expect the button to one or the other
> > based on the software stack.
> >
> > Or are both possible at the same time, and there are devices with both
> > buttons?
> >
> > Seems that adding a note that other similar "pairing" methods for Wi-Fi
> > could be triggered when the button is used, in input.h would be enough.
> 
> I think it's just a software thing (some EAP messages probably).
> 
> Thanks for your comments!
> 
> What about KEY_WWAN. Does it make sense to add it?

If there are "keys" with that sort of label, it would make sense to me.

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html