From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Qi.Chen@windriver.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 01/18] linux-firmware: de-bash scripts to remove bash dependency
Date: Fri, 29 Nov 2013 13:23:25 +0000 [thread overview]
Message-ID: <1385731405.11222.58.camel@ted> (raw)
In-Reply-To: <d19d1002b079e65e04e1efc97e90d49c55f8233b.1385728901.git.Qi.Chen@windriver.com>
On Fri, 2013-11-29 at 20:48 +0800, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> De-bash some script in linux-firmware to make it not dependent on
> bash.
>
> [YOCTO #5555]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> .../files/0001-linux-firmware-de-bash.patch | 47 ++++++++++++++++++++
> .../linux-firmware/linux-firmware_git.bb | 3 +-
> 2 files changed, 49 insertions(+), 1 deletion(-)
> create mode 100644 meta/recipes-kernel/linux-firmware/files/0001-linux-firmware-de-bash.patch
We shouldn't even ship these files, its pointless. I have an alternative
patch to propose.
Cheers,
Richard
> diff --git a/meta/recipes-kernel/linux-firmware/files/0001-linux-firmware-de-bash.patch b/meta/recipes-kernel/linux-firmware/files/0001-linux-firmware-de-bash.patch
> new file mode 100644
> index 0000000..223a45f
> --- /dev/null
> +++ b/meta/recipes-kernel/linux-firmware/files/0001-linux-firmware-de-bash.patch
> @@ -0,0 +1,47 @@
> +Upstream-Status: Pending
> +
> +Subject: linux-firmware: de-bash
> +
> +Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> +
> +---
> + carl9170fw/autogen.sh | 7 ++++---
> + configure | 2 +-
> + 2 files changed, 5 insertions(+), 4 deletions(-)
> +
> +diff --git a/carl9170fw/autogen.sh b/carl9170fw/autogen.sh
> +index 6843f19..a340427 100755
> +--- a/carl9170fw/autogen.sh
> ++++ b/carl9170fw/autogen.sh
> +@@ -1,14 +1,15 @@
> +-#!/bin/bash
> ++#!/bin/sh
> +
> + set -e
> +
> + case "$1" in
> + config)
> + echo "Configuring..."
> +- pushd config
> ++ cwd=`pwd`
> ++ cd config
> + cmake .
> + make
> +- popd
> ++ cd $cwd
> + config/conf Kconfig
> + cmake .
> + ;;
> +diff --git a/configure b/configure
> +index 3260f9a..5e930f1 100644
> +--- a/configure
> ++++ b/configure
> +@@ -1,4 +1,4 @@
> +-#!/bin/bash
> ++#!/bin/sh
> + # -*- mode: sh -*-
> + # Our Makefile doesn't do srcdir != builddir
> + #buildapi-variable-no-builddir
> +--
> +1.7.9.5
> +
> diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> index fe6730a..ec463bf 100644
> --- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> @@ -28,7 +28,8 @@ SRCREV = "600caefd83a406540b2a789be6415e44c9b87add"
> PE = "1"
> PV = "0.0+git${SRCPV}"
>
> -SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git"
> +SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git \
> + file://0001-linux-firmware-de-bash.patch"
>
> S = "${WORKDIR}/git"
>
next prev parent reply other threads:[~2013-11-29 13:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 12:48 [PATCH 00/18] Fix the problem of implicit bash dependency Qi.Chen
2013-11-29 12:48 ` [PATCH 01/18] linux-firmware: de-bash scripts to remove " Qi.Chen
2013-11-29 13:23 ` Richard Purdie [this message]
2013-12-02 1:55 ` ChenQi
2013-11-29 12:48 ` [PATCH 02/18] apr: make the dev package rdepend on bash Qi.Chen
2013-11-29 12:48 ` [PATCH 03/18] libpam: make libpam-xtests " Qi.Chen
2013-11-29 12:48 ` [PATCH 04/18] hdparm: make wiper appear before hdparm in PACKAGES Qi.Chen
2013-11-29 12:48 ` [PATCH 05/18] lsb: de-bash scripts to remove bash dependency Qi.Chen
2013-11-29 12:48 ` [PATCH 06/18] xz: rdepend on bash Qi.Chen
2013-12-03 0:57 ` Randy MacLeod
2013-11-29 12:48 ` [PATCH 07/18] dtc: make dtc-misc " Qi.Chen
2013-11-29 12:48 ` [PATCH 08/18] lsbtest: de-bash script to remove bash dependency Qi.Chen
2013-11-29 12:48 ` [PATCH 09/18] libtool: explicitly rdepend on bash Qi.Chen
2013-11-29 12:48 ` [PATCH 10/18] rpm: fix RDEPENDS for rpm-build Qi.Chen
2013-11-29 12:48 ` [PATCH 11/18] nfs-utils: add bash to RDEPENDS Qi.Chen
2013-11-29 12:48 ` [PATCH 12/18] apt: explicitly rdepend on bash Qi.Chen
2013-11-29 12:48 ` [PATCH 13/18] gzip: " Qi.Chen
2013-12-03 0:59 ` Randy MacLeod
2013-11-29 12:48 ` [PATCH 14/18] pm-utils: " Qi.Chen
2013-11-29 12:48 ` [PATCH 15/18] ltp: " Qi.Chen
2013-11-29 12:48 ` [PATCH 16/18] kconfig-frontends: " Qi.Chen
2013-11-29 12:48 ` [PATCH 17/18] pax-utils: add bash runtime dependency Qi.Chen
2013-11-29 12:48 ` [PATCH 18/18] kernel.bbclass: make kernel-dev explicitly rdepend on bash Qi.Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385731405.11222.58.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.