From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v4 02/15] libxl: sanitize error handling in libxl_get_max_{cpus, nodes} Date: Mon, 2 Dec 2013 19:21:28 +0100 Message-ID: <1386008488.5338.222.camel@Solace> References: <20131122183332.11200.20231.stgit@Solace> <20131122185649.11200.73393.stgit@Solace> <1385559900.23112.199.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5511967162350394550==" Return-path: In-Reply-To: <1385559900.23112.199.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Marcus Granado , Keir Fraser , Jan Beulich , Li Yechen , George Dunlap , Andrew Cooper , Juergen Gross , Ian Jackson , xen-devel@lists.xen.org, Matt Wilson , Justin Weaver , Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org --===============5511967162350394550== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-GNs/+0y1LrpH7cKD0O1S" --=-GNs/+0y1LrpH7cKD0O1S Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mer, 2013-11-27 at 13:45 +0000, Ian Campbell wrote: > On Fri, 2013-11-22 at 19:56 +0100, Dario Faggioli wrote: > > =20 > > cpumap->map =3D xc_cpupool_freeinfo(ctx->xch); > > diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c > > index 9f5f589..1815422 100644 > > --- a/tools/libxl/libxl_utils.c > > +++ b/tools/libxl/libxl_utils.c > > @@ -651,6 +651,56 @@ char *libxl_bitmap_to_hex_string(libxl_ctx *ctx, c= onst libxl_bitmap *bitmap) > > return q; > > } > > =20 > > +int libxl_cpu_bitmap_alloc(libxl_ctx *ctx, libxl_bitmap *cpumap, int m= ax_cpus) >=20 > You seem to have combined code motion with actual changes here. Please > don't do that. >=20 As I explained in the commit message for this patch in v5, I actually am both moving and (slightly) changing the functions, and that's mainly because the changes I'm doing require the move (e.g., GC_INIT/GC_FREE not being available in the original place). I feel like it's more natural to do like this, rather than having a pre-patch just moving the code for no apparent reason... Isn't it? Or was it something else that you were pointing out? (Anyway, feel free to look at v5 and reply there). Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-GNs/+0y1LrpH7cKD0O1S Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKcz6gACgkQk4XaBE3IOsQRCgCfeU6nJOYHfOUNoFNdlak4/N0p 14kAoJQtuqaCO9hjjpoptvd3/2KfhgHB =uZ8h -----END PGP SIGNATURE----- --=-GNs/+0y1LrpH7cKD0O1S-- --===============5511967162350394550== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5511967162350394550==--