From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v4 02/15] libxl: sanitize error handling in libxl_get_max_{cpus, nodes} Date: Tue, 3 Dec 2013 13:06:56 +0100 Message-ID: <1386072416.5338.316.camel@Solace> References: <20131122183332.11200.20231.stgit@Solace> <20131122185649.11200.73393.stgit@Solace> <1385559900.23112.199.camel@kazak.uk.xensource.com> <1386008488.5338.222.camel@Solace> <1386063680.16012.42.camel@kazak.uk.xensource.com> <1386070811.5338.300.camel@Solace> <1386071138.13256.19.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2403069349055073303==" Return-path: In-Reply-To: <1386071138.13256.19.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Marcus Granado , Keir Fraser , Jan Beulich , Li Yechen , George Dunlap , Andrew Cooper , Juergen Gross , Ian Jackson , xen-devel@lists.xen.org, Matt Wilson , Justin Weaver , Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org --===============2403069349055073303== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-YIMDI8ySxzqQ+PuzcXNl" --=-YIMDI8ySxzqQ+PuzcXNl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2013-12-03 at 11:45 +0000, Ian Campbell wrote: > On Tue, 2013-12-03 at 12:40 +0100, Dario Faggioli wrote: > > So, my view here is: if I modify the function, adding GC and the LOG()s= , > > then it should also be moved, if not, it can stay where it is. What you > > seem to be suggesting is that I (either in this or a previous patch) > > move the function as is, for no apparent reason, >=20 > It's not for "no apparent reason", it is to separate code motion from > reworking the function, which you would explain in your commit message. >=20 Ok then. > If that were considered no apparent reason then it wouldn't be possible > to split the code motion from the functional changes in the majority of > cases. >=20 Right. Thanks for the explanation, and sorry for not getting what you mean/want sooner. It just differs from the way I've done things up to now, so I really wasn't sure I was understanding, rather than not wanting to do it. :-) Will do. Thanks again and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-YIMDI8ySxzqQ+PuzcXNl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKdyWAACgkQk4XaBE3IOsRPEgCdH0YeMJGK88NAO23ApxGy60jI tCsAnjXh50NZ2IZXvO0YdXmbW0R2iFBh =cfJS -----END PGP SIGNATURE----- --=-YIMDI8ySxzqQ+PuzcXNl-- --===============2403069349055073303== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2403069349055073303==--