From: Johannes Berg <johannes@sipsolutions.net>
To: Rajesh Chauhan <rajeshc@qca.qualcomm.com>
Cc: rodrigue@qca.qualcomm.com, linux-wireless@vger.kernel.org,
jouni@qca.qualcomm.com, hbahini@qca.qualcomm.com,
jjohnson@qca.qualcomm.com, schang@qca.qualcomm.com,
xunl@qca.qualcomm.com, sameert@qca.qualcomm.com,
c_arifh@qca.qualcomm.com
Subject: Re: [PATCHv3] cfg80211: add support for frequency interference event
Date: Tue, 03 Dec 2013 16:06:43 +0100 [thread overview]
Message-ID: <1386083203.4393.35.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1386077130.4393.21.camel@jlt4.sipsolutions.net> (sfid-20131203_142537_442351_B9A4DE15)
On Tue, 2013-12-03 at 14:25 +0100, Johannes Berg wrote:
> > + if (nla_put_u32(msg, NL80211_ATTR_WIPHY, rdev->wiphy_idx) ||
> > + nla_put_u32(msg, NL80211_ATTR_IFINDEX, netdev->ifindex))
> > + goto nla_put_failure;
>
> wdev index is missing, however, see above.
Forgot add the "see above" part, so I'll just put it here:
I don't think this API makes sense per netdev.
johannes
next prev parent reply other threads:[~2013-12-03 15:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 19:32 [PATCHv3] cfg80211: add support for frequency interference event Rajesh Chauhan
2013-11-14 9:54 ` Luis R. Rodriguez
2013-11-15 18:53 ` Chauhan, Rajesh
2013-11-17 9:17 ` Johannes Berg
2013-12-03 13:25 ` Johannes Berg
2013-12-03 15:06 ` Johannes Berg [this message]
2013-12-03 16:35 ` Luis R. Rodriguez
2013-12-04 8:20 ` Johannes Berg
2013-12-04 8:20 ` Johannes Berg
2013-12-20 7:44 ` Chauhan, Rajesh
2013-12-20 8:11 ` Luis R. Rodriguez
2013-12-20 8:16 ` BAHINI, Henri
2013-12-20 8:26 ` Luis R. Rodriguez
2013-12-20 8:30 ` BAHINI, Henri
2013-12-20 8:37 ` Luis R. Rodriguez
2013-12-20 8:45 ` BAHINI, Henri
2014-01-06 16:38 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386083203.4393.35.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=c_arifh@qca.qualcomm.com \
--cc=hbahini@qca.qualcomm.com \
--cc=jjohnson@qca.qualcomm.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rajeshc@qca.qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
--cc=sameert@qca.qualcomm.com \
--cc=schang@qca.qualcomm.com \
--cc=xunl@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.