From: Johannes Berg <johannes@sipsolutions.net>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/8] mac80211: speed up station cleanup/AP shutdown
Date: Thu, 05 Dec 2013 18:27:28 +0100 [thread overview]
Message-ID: <1386264448.4182.19.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1952067.PDj1Tev3s2@blech> (sfid-20131205_180211_819129_F0306273)
On Thu, 2013-12-05 at 18:02 +0100, Christian Lamparter wrote:
> On Thursday, December 05, 2013 01:35:48 PM Johannes Berg wrote:
> > Inspired by hostap shutdown potentially taking a long time (which is
> > in part also its fault), I took a closer look at the station removal
> > code and I think it's too complex. Only a single driver (iwlmvm) has
> > a need for an RCU grace period after sta_state() returns, and that
> > can easily be addressed differently.
> >
> > So consolidate many of the synchronize_rcu()/_net() in these paths
> > and get rid of the rcu_barrier() stuff completely.
> >
> > Testing is still pending, but it should improve timing.
>
> So far, I see no crashes or other undefined behavior with
> current carl9170 driver.
Cool. What I wrote came out bad - I did test that it still works with
hwsim and iwlwifi, but I didn't get any *timing* testing yet :)
johannes
next prev parent reply other threads:[~2013-12-05 17:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 21:30 question for mac80211 driver maintainers - RCU usage in drivers Johannes Berg
2013-12-04 22:16 ` Christian Lamparter
2013-12-04 22:23 ` Johannes Berg
2013-12-04 22:47 ` Christian Lamparter
2013-12-04 22:51 ` Johannes Berg
2013-12-05 12:35 ` [PATCH 0/8] mac80211: speed up station cleanup/AP shutdown Johannes Berg
2013-12-05 12:35 ` [PATCH 1/8] mac80211: add pre-RCU-sync sta removal driver operation Johannes Berg
2013-12-05 12:35 ` [PATCH 2/8] iwlwifi: mvm: use pre-RCU-sync sta removal operation Johannes Berg
2013-12-05 12:35 ` [PATCH 3/8] mac80211: move 4-addr sta pointer clearing before synchronize_rcu() Johannes Berg
2013-12-05 12:35 ` [PATCH 4/8] mac80211: don't delay station destruction Johannes Berg
2013-12-05 12:35 ` [PATCH 5/8] mac80211: move synchronize_net() before sta key removal Johannes Berg
2013-12-05 12:35 ` [PATCH 6/8] mac80211: optimise synchronize_net() for sta_info_flush Johannes Berg
2013-12-05 12:35 ` [PATCH 7/8] mac80211: optimise mixed AP/VLAN station removal Johannes Berg
2013-12-05 12:35 ` [PATCH 8/8] mac80211: free all AP/VLAN keys at once Johannes Berg
2013-12-05 17:02 ` [PATCH 0/8] mac80211: speed up station cleanup/AP shutdown Christian Lamparter
2013-12-05 17:27 ` Johannes Berg [this message]
2013-12-16 10:30 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386264448.4182.19.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.