From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v5 04/17] libxc/libxl: sanitize error handling in *_get_max_{cpus, nodes} Date: Fri, 6 Dec 2013 11:34:55 +0100 Message-ID: <1386326095.5338.584.camel@Solace> References: <20131202180129.29026.81543.stgit@Solace> <20131202182749.29026.5880.stgit@Solace> <21152.27961.283265.921654@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8984524464364699088==" Return-path: In-Reply-To: <21152.27961.283265.921654@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Marcus Granado , Keir Fraser , Ian Campbell , Li Yechen , George Dunlap , Andrew Cooper , Juergen Gross , xen-devel@lists.xen.org, Jan Beulich , Justin Weaver , Matt Wilson , Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org --===============8984524464364699088== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-9OG5msnkwUIf5OMMIJPR" --=-9OG5msnkwUIf5OMMIJPR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On gio, 2013-12-05 at 12:10 +0000, Ian Jackson wrote: > Dario Faggioli writes ("[PATCH v5 04/17] libxc/libxl: sanitize error hand= ling in *_get_max_{cpus, nodes}"): > > In libxc, make xc_get_max_{cpus,node}() always return either a > > positive number or -1, and change all the callers to deal with > > that. > >=20 > > In libxl, make libxl_get_max_{cpus,nodes}() always return either a > > positive number or a libxl error code. Thanks to that, it is also > > possible to fix loggig for libxl_{cpu,node}_bitmap_alloc(), which > > now happens inside the functions themselves, more accurately > > reporting what happened. > >=20 > > Note that libxl_{cpu,node}_bitmap_alloc() are also moved to > > libxl_utils.c as, apart from having become less trivial and hence > > better suited there, that's required for using GC_INIT()/GC_FREE, > > which in turn is needed for the LOG()/LOGE() macros. > >=20 > > Signed-off-by: Dario Faggioli > > Acked-by: George Dunlap >=20 > Acked-by: Ian Jackson >=20 So, are these going to be committed, at some point before RC0? I'm talking about the first half of the series, i.e., patches 1 to 8, containint _not_ the soft affinity work, but just fixes for and libxl and the node-wise specification of vcpu pinning for xl. Here's the current situation, as far as I can tell: a xl: match output of vcpu-list with pinning syntax a libxl: better name for last parameter of libxl_list_vcpu a libxl: fix memory leak in libxl_list_vcpu a libxc/libxl: sanitize error handling in *_get_max_{cpus,nodes} a libxc/libxl: allow to retrieve the number of online pCPUs ra xl: allow for node-wise specification of vcpu pinning a xl: implement and enable dryrun mode for `xl vcpu-pin' a xl: test script for the cpumap parser (for vCPU pinning) r =3D has been 'Reviewed-by' a =3D has been 'Acked-by' Should I resend that part of the series with all the Ack-s? Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-9OG5msnkwUIf5OMMIJPR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKhqE8ACgkQk4XaBE3IOsSEcACeJKEEFktBkMGqKlGnh6q6h7XN Dc0AnROObSPyxma4N9edGXoXluSy1c6J =MG+x -----END PGP SIGNATURE----- --=-9OG5msnkwUIf5OMMIJPR-- --===============8984524464364699088== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8984524464364699088==--