From: deepak.s@intel.com
To: intel-gfx@lists.freedesktop.org
Cc: Deepak S <deepak.s@intel.com>
Subject: [PATCH 1/3] drm/i915: Verify address field of PCBR register.
Date: Sun, 8 Dec 2013 13:52:35 +0530 [thread overview]
Message-ID: <1386490955-20608-1-git-send-email-deepak.s@intel.com> (raw)
From: Deepak S <deepak.s@intel.com>
On VLV the PCBR register has other bits besides the pcbr address
field. Verify only address field setup by BIOS to make sure we don't
misinterpret the PCBR setup.
Signed-off-by: Deepak S <deepak.s@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index e6d98fe..2e1340f 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4036,7 +4036,12 @@ static void valleyview_setup_pctx(struct drm_device *dev)
int pctx_size = 24*1024;
pcbr = I915_READ(VLV_PCBR);
- if (pcbr) {
+
+ /* PCBR Format: Bits 31:12 - Base address of Process Context
+ * Bits 11:1 - Reserved
+ * Bit 0 - PCBR Lock
+ * Check only address field if already setup by BIOS */
+ if (pcbr >> 12) {
/* BIOS set it up already, grab the pre-alloc'd space */
int pcbr_offset;
--
1.8.4.2
next reply other threads:[~2013-12-08 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-08 8:22 deepak.s [this message]
2013-12-09 7:58 ` [PATCH 1/3] drm/i915: Verify address field of PCBR register Daniel Vetter
2013-12-09 9:35 ` Ville Syrjälä
2013-12-09 14:17 ` S, Deepak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386490955-20608-1-git-send-email-deepak.s@intel.com \
--to=deepak.s@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.