From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org,
Liu Ping Fan <kernelfans@gmail.com>
Subject: Re: [PATCH 1/3] powerpc: mm: make _PAGE_NUMA take effect
Date: Mon, 09 Dec 2013 11:31:52 +1100 [thread overview]
Message-ID: <1386549112.5159.4.camel@pasglop> (raw)
In-Reply-To: <87a9gfva9n.fsf@linux.vnet.ibm.com>
On Thu, 2013-12-05 at 16:23 +0530, Aneesh Kumar K.V wrote:
> Liu Ping Fan <kernelfans@gmail.com> writes:
>
> > To enable the do_numa_page(), we should not fix _PAGE_NUMA in
> > hash_page(), so bail out for the case of pte_numa().
For some reason I don't have 2/3 and 3/3 in my mbox (though I do have
them on patchwork) so I'll reply to this one.
Overall, your statement that this is a faster path needs to be backed up
with numbers.
The code is complicated enough as it-is, such additional mess in the low
level hashing code requires a good justification, and also a
demonstration that it doesn't add overhead to the normal hash path.
Cheers,
Ben.
next prev parent reply other threads:[~2013-12-09 0:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 6:59 [PATCH 0/3] optimize for powerpc _PAGE_NUMA Liu Ping Fan
2013-12-04 6:59 ` [PATCH 1/3] powerpc: mm: make _PAGE_NUMA take effect Liu Ping Fan
2013-12-05 10:53 ` Aneesh Kumar K.V
2013-12-09 0:31 ` Benjamin Herrenschmidt [this message]
2013-12-09 6:17 ` Liu ping fan
2013-12-09 6:19 ` Benjamin Herrenschmidt
2013-12-11 8:50 ` Liu ping fan
2013-12-11 9:50 ` Benjamin Herrenschmidt
2013-12-12 2:19 ` Liu ping fan
2013-12-04 6:59 ` [PATCH 2/3] mm: export numa_migrate_prep() Liu Ping Fan
2013-12-04 6:59 ` [PATCH 3/3] powerpc: mm: optimize for the correctly placed page Liu Ping Fan
2013-12-05 10:58 ` Aneesh Kumar K.V
2013-12-05 13:27 ` Liu ping fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386549112.5159.4.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=kernelfans@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.