From: Ethan Zhao <ethan.kernel@gmail.com>
To: stefano.stabellini@eu.citrix.com, konrad.wilk@oracle.com,
raghavendra.kt@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, Ethan Zhao <ethan.kernel@gmail.com>
Subject: [PATCH v4] xen/debugfs: Check debugfs initialization before using it
Date: Mon, 9 Dec 2013 18:58:40 +0800 [thread overview]
Message-ID: <1386586720-789-1-git-send-email-ethan.kernel@gmail.com> (raw)
Should check debugfs initialization with debugfs_initialized() before using it,
Because if it isn't initialized, the return value of fake debugfs_create_dir() etc
functions would be ERR_PTR(-ENODEV), checking with NULL will not work.
V2: change author name to normative format.
V3: add warning message about debugfs not configured or disabled.
V4: make the warning clear.
Signed-off-by: Ethan Zhao <ethan.kernel@gmail.com>
---
arch/x86/xen/debugfs.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/x86/xen/debugfs.c b/arch/x86/xen/debugfs.c
index c8377fb..7f3804c 100644
--- a/arch/x86/xen/debugfs.c
+++ b/arch/x86/xen/debugfs.c
@@ -9,12 +9,19 @@ static struct dentry *d_xen_debug;
struct dentry * __init xen_init_debugfs(void)
{
+ if (!debugfs_initialized()) {
+ d_xen_debug = NULL;
+ pr_warning("Debugfs is not configured or not enabled\n");
+ goto nodebugfs;
+ }
+
if (!d_xen_debug) {
d_xen_debug = debugfs_create_dir("xen", NULL);
if (!d_xen_debug)
pr_warning("Could not create 'xen' debugfs directory\n");
}
+nodebugfs:
return d_xen_debug;
}
--
1.8.3.4 (Apple Git-47)
reply other threads:[~2013-12-09 11:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386586720-789-1-git-send-email-ethan.kernel@gmail.com \
--to=ethan.kernel@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.