All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Stephane Eranian <eranian@google.com>
Subject: [PATCH 2/4] perf tools: Fix max mmap_pages
Date: Mon,  9 Dec 2013 15:18:38 +0200	[thread overview]
Message-ID: <1386595120-22978-3-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1386595120-22978-1-git-send-email-adrian.hunter@intel.com>

'SIZE_MAX / page_size' is an upper limit for
the maximum number of mmap pages, not a lower
limit.  Change the condition accordingly.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 tools/perf/util/evlist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 4d0945c..98ec96b 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -754,7 +754,7 @@ int perf_evlist__parse_mmap_pages(const struct option *opt, const char *str,
 	unsigned long max = UINT_MAX;
 	long pages;
 
-	if (max < SIZE_MAX / page_size)
+	if (max > SIZE_MAX / page_size)
 		max = SIZE_MAX / page_size;
 
 	pages = parse_pages_arg(str, 1, max);
-- 
1.7.11.7


  parent reply	other threads:[~2013-12-09 13:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09 13:18 [PATCH 0/4] perf tools: Pedantic fixes for mmap_pages Adrian Hunter
2013-12-09 13:18 ` [PATCH 1/4] perf tools: Remove unnecessary parentheses Adrian Hunter
2013-12-11 11:04   ` [tip:perf/core] perf evlist: " tip-bot for Adrian Hunter
2013-12-09 13:18 ` Adrian Hunter [this message]
2013-12-09 13:35   ` [PATCH 2/4] perf tools: Fix max mmap_pages Jiri Olsa
2013-12-09 14:00     ` Adrian Hunter
2013-12-11 11:04   ` [tip:perf/core] perf evlist: " tip-bot for Adrian Hunter
2013-12-09 13:18 ` [PATCH 3/4] perf tools: Fix mmap pages rounding to power of 2 Adrian Hunter
2013-12-11 11:04   ` [tip:perf/core] perf evlist: " tip-bot for Adrian Hunter
2013-12-09 13:18 ` [PATCH 4/4] perf tools: Fix display of incorrect mmap pages Adrian Hunter
2013-12-11 11:04   ` [tip:perf/core] perf record: " tip-bot for Adrian Hunter
2013-12-09 13:44 ` [PATCH 0/4] perf tools: Pedantic fixes for mmap_pages Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386595120-22978-3-git-send-email-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.