All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Röjfors" <richard.rojfors@gmail.com>
To: backports@vger.kernel.org
Subject: [PATCH] compat.3.7, compat.3.8: Adds missing of.h include
Date: Tue, 10 Dec 2013 16:36:10 +0100	[thread overview]
Message-ID: <1386689770.5956.4.camel@asus> (raw)

This applies to 3.13-rc2

The compat-3.7.c och compat-3.8.c uses of-functions if supported by the
kernel, but there is a missing include for linux/of.h.

This patch fixes the compile error which looks like this:

| NOTE: make -j 8 ARCH=arm KLIB_BUILD=/path/usr/src/kernel KLIB=/path/image
|   CC [M]  /path/backports-3.13-rc2-1/compat/compat-3.7.o
| /path/backports-3.13-rc2-1/compat/compat-3.7.c: In function 'of_get_child_by_name':
| /path/backports-3.13-rc2-1/compat/compat-3.7.c:274:1: error: unknown type name 'z'
| /path/backports-3.13-rc2-1/compat/compat-3.7.c:276:3: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'if'
| make[6]: *** [/path/backports-3.13-rc2-1/compat/compat-3.7.o] Error 1
| make[5]: *** [/path/backports-3.13-rc2-1/compat] Error 2
| make[4]: *** [_module_/path/backports/3.13-rc2-1-r0/backports-3.13-rc2-1] Error 2
| make[3]: *** [modules] Error 2
| make[2]: *** [modules] Error 2
| make[1]: *** [modules] Error 2
| make: *** [default] Error 2

Signed-off-by: Richard Röjfors <richard.rojfors@gmail.com>
---
--- backports-3.13-rc2-1.org/compat/compat-3.7.c	2013-12-05 12:19:56.161016836 +0100
+++ backports-3.13-rc2-1.new/compat/compat-3.7.c	2013-12-05 12:18:40.257012431 +0100
@@ -256,6 +256,8 @@
 
 #ifdef CONFIG_OF
 #if (LINUX_VERSION_CODE < KERNEL_VERSION(3,7,0))
+#include <linux/of.h>
+
 /**
  *	of_get_child_by_name - Find the child node by name for a given parent
  *	@node:	parent node
--- backports-3.13-rc2-1.org/compat/compat-3.8.c	2013-12-05 12:17:53.093009694 +0100
+++ backports-3.13-rc2-1.new/compat/compat-3.8.c	2013-12-05 12:18:42.745012576 +0100
@@ -420,6 +420,8 @@
 EXPORT_SYMBOL_GPL(vm_iomap_memory);
 
 #ifdef CONFIG_OF
+#include <linux/of.h>
+
 /**
  * of_find_property_value_of_size
  *


             reply	other threads:[~2013-12-10 15:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 15:36 Richard Röjfors [this message]
2014-01-17 21:31 ` [PATCH] compat.3.7, compat.3.8: Adds missing of.h include Hauke Mehrtens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386689770.5956.4.camel@asus \
    --to=richard.rojfors@gmail.com \
    --cc=backports@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.