From: Eric Leblond <eric@regit.org>
To: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH ulogd] ulogd: use AC_SEARCH_LIBS for libpthread
Date: Wed, 11 Dec 2013 09:03:12 +0100 [thread overview]
Message-ID: <1386748992.4710.6.camel@ice-age2.regit.org> (raw)
In-Reply-To: <1386678252-6853-1-git-send-email-gustavo@zacarias.com.ar>
Hello,
On Tue, 2013-12-10 at 09:24 -0300, Gustavo Zacarias wrote:
> Some uClibc-based toolchains lack threading support, so use
> AC_SEARCH_LIB instead of AC_CHECK_LIB to check for libpthread
> availability and link conditionally if found since it's only used for
> the database backends.
Thanks a lot. Patch pushed to git.
BR,
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> configure.ac | 3 ++-
> src/Makefile.am | 4 ++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 7f5ffa9..5e45aaa 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -39,7 +39,8 @@ AC_CHECK_FUNCS(socket strerror)
> regular_CFLAGS="-Wall -Wextra -Wno-unused-parameter"
> AC_SUBST([regular_CFLAGS])
>
> -AC_CHECK_LIB(pthread, pthread_create)
> +AC_SEARCH_LIBS([pthread_create], [pthread], [libpthread_LIBS="$LIBS"; LIBS=""])
> +AC_SUBST([libpthread_LIBS])
>
> dnl Check for the right nfnetlink version
> PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 1097468..998e776 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -7,5 +7,5 @@ AM_CFLAGS = ${regular_CFLAGS}
> sbin_PROGRAMS = ulogd
>
> ulogd_SOURCES = ulogd.c select.c timer.c rbtree.c conffile.c hash.c addr.c
> -ulogd_LDADD = ${libdl_LIBS}
> -ulogd_LDFLAGS = -export-dynamic -lpthread
> +ulogd_LDADD = ${libdl_LIBS} ${libpthread_LIBS}
> +ulogd_LDFLAGS = -export-dynamic
--
Eric Leblond <eric@regit.org>
prev parent reply other threads:[~2013-12-11 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 12:24 [PATCH ulogd] ulogd: use AC_SEARCH_LIBS for libpthread Gustavo Zacarias
2013-12-11 0:46 ` Eric Leblond
2013-12-11 0:56 ` Gustavo Zacarias
2013-12-11 8:03 ` Eric Leblond [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386748992.4710.6.camel@ice-age2.regit.org \
--to=eric@regit.org \
--cc=gustavo@zacarias.com.ar \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.