From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH RFC V2 4/6] Introduce ts-ovmf-debian-install
Date: Thu, 12 Dec 2013 09:49:11 +0100
Message-ID: <1386838151.5488.90.camel@Solace>
References: <1386778305-29995-1-git-send-email-wei.liu2@citrix.com>
	<1386778305-29995-5-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2378496077574819372=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1386778305-29995-5-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============2378496077574819372==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-rTRyRrcDtf6djdzlRJdQ"

--=-rTRyRrcDtf6djdzlRJdQ
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On mer, 2013-12-11 at 16:11 +0000, Wei Liu wrote:
> diff --git a/ts-ovmf-debian-install b/ts-ovmf-debian-install
> new file mode 100755
> index 0000000..2e19348
> --- /dev/null
> +++ b/ts-ovmf-debian-install

> +sub start () {
> +    target_cmd_root($ho, "$xl create $gho->{CfgPath}", 100);
> +}
> +
Something like "toolstack()->{Command}" instead of "xl" ?

I don't know how important this is, though, as I don't think this has
much chances to work with xend, has it?

> +rewrite_config_nocd();
> +start();
> +guest_await_dhcp_tcp($gho,300);
> +guest_check_up($gho);
>
Does this mean that the guest remains up after the end of the test? This
is also probably not a big deal, but, shouldn't we tear it down?

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-rTRyRrcDtf6djdzlRJdQ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iEYEABECAAYFAlKpeIgACgkQk4XaBE3IOsT21ACgo3GG6kwU1yyjlBO8buxf4tsj
Un4Anjff2mI6NUhLjPh6wcwes2UNjhk/
=vZKw
-----END PGP SIGNATURE-----

--=-rTRyRrcDtf6djdzlRJdQ--


--===============2378496077574819372==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============2378496077574819372==--