From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC V2 4/6] Introduce ts-ovmf-debian-install Date: Thu, 12 Dec 2013 13:24:19 +0100 Message-ID: <1386851059.5488.102.camel@Solace> References: <1386778305-29995-1-git-send-email-wei.liu2@citrix.com> <1386778305-29995-5-git-send-email-wei.liu2@citrix.com> <1386838151.5488.90.camel@Solace> <20131212121622.GA21900@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9103723628031590627==" Return-path: In-Reply-To: <20131212121622.GA21900@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.jackson@eu.citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============9103723628031590627== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-4eWf6YvXwbDr+DCMPjXE" --=-4eWf6YvXwbDr+DCMPjXE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On gio, 2013-12-12 at 12:16 +0000, Wei Liu wrote: > On Thu, Dec 12, 2013 at 09:49:11AM +0100, Dario Faggioli wrote: > > On mer, 2013-12-11 at 16:11 +0000, Wei Liu wrote: > > > diff --git a/ts-ovmf-debian-install b/ts-ovmf-debian-install > > > new file mode 100755 > > > index 0000000..2e19348 > > > --- /dev/null > > > +++ b/ts-ovmf-debian-install > >=20 > > > +sub start () { > > > + target_cmd_root($ho, "$xl create $gho->{CfgPath}", 100); > > > +} > > > + > > Something like "toolstack()->{Command}" instead of "xl" ? > >=20 >=20 > $xl is in fact toolstack()->{Command}. >=20 I know. > > I don't know how important this is, though, as I don't think this has > > much chances to work with xend, has it? > >=20 >=20 > No. Xend is deprecated so I don't bother fiddling with that. >=20 Ok. I was also thinking that keeping these things general and abstract enough would be better if, at some point, we'd like to intdocude other toolstack (e.g., virsh/libvirt). However, changes will be needed anyway, e.g., to the "create" part... so, yeah, I guess this is a non issue. > > Does this mean that the guest remains up after the end of the test? Thi= s > > is also probably not a big deal, but, shouldn't we tear it down? > >=20 >=20 > I copied this from ts-redhat-install. >=20 You're right, sorry for this. I thought I see gests being teared down somewhere, but just finished running a (similar) test myself, and the guest is up. Sorry again for the noise. :-) Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-4eWf6YvXwbDr+DCMPjXE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKpqvMACgkQk4XaBE3IOsQxeQCeJ+htJR2XSEik6CMJCyyRFQdF ua8An00kTZXSWgl4Sb5ZLj3cgimbHvxn =pA2Q -----END PGP SIGNATURE----- --=-4eWf6YvXwbDr+DCMPjXE-- --===============9103723628031590627== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============9103723628031590627==--