From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH RFC V2 4/6] Introduce ts-ovmf-debian-install
Date: Thu, 12 Dec 2013 17:37:37 +0100
Message-ID: <1386866257.5488.118.camel@Solace>
References: <1386778305-29995-1-git-send-email-wei.liu2@citrix.com>
	<1386778305-29995-5-git-send-email-wei.liu2@citrix.com>
	<1386838151.5488.90.camel@Solace>
	<20131212121622.GA21900@zion.uk.xensource.com>
	<1386851059.5488.102.camel@Solace>
	<21161.58272.84619.567681@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3474429436687990461=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21161.58272.84619.567681@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, ian.campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============3474429436687990461==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-gTKvXlCqu22JZcUxwhpt"

--=-gTKvXlCqu22JZcUxwhpt
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On gio, 2013-12-12 at 16:26 +0000, Ian Jackson wrote:
> Dario Faggioli writes ("Re: [Xen-devel] [PATCH RFC V2 4/6] Introduce ts-o=
vmf-debian-install"):
> > On gio, 2013-12-12 at 12:16 +0000, Wei Liu wrote:
> > > $xl is in fact toolstack()->{Command}.
> >=20
> > I know.
>=20
> So err, I'm not sure what your point was.  Wei's code seems correct to
> me.
>=20
My point was that, even if it's obviously true that
toolstack()->{Command}=3D=3Dxl, and hence Wei's code looks correct to me
too, we better use toolstack()->{Command}.

> > > > I don't know how important this is, though, as I don't think this h=
as
> > > > much chances to work with xend, has it?
> > >=20
> > > No. Xend is deprecated so I don't bother fiddling with that.
>=20
> I think it's better to be consistent and always use
> toolstack()->{Command} even in tests which aren't going to work with
> xend.
>=20
So, err... Exactly my point. :-)

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-gTKvXlCqu22JZcUxwhpt
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iEYEABECAAYFAlKp5lEACgkQk4XaBE3IOsRn9ACfcsRCvrwMfcdAhGIwoVrIe9aA
8vcAn2tREabj23RzeP8TSKjf//fHNQHQ
=tC4I
-----END PGP SIGNATURE-----

--=-gTKvXlCqu22JZcUxwhpt--


--===============3474429436687990461==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3474429436687990461==--