From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [OSSTest PATCH [RFC] 2/4] ts-fedora-install: added for installing fedora guests Date: Fri, 13 Dec 2013 18:36:11 +0100 Message-ID: <1386956171.3980.27.camel@Solace> References: <20131212221933.11164.46804.stgit@Solace> <20131212225332.11164.99188.stgit@Solace> <21163.14777.408700.773459@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4388209017353645377==" Return-path: In-Reply-To: <21163.14777.408700.773459@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============4388209017353645377== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-qVcMXY9G03kFuSZL+70J" --=-qVcMXY9G03kFuSZL+70J Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On ven, 2013-12-13 at 16:45 +0000, Ian Jackson wrote: > Dario Faggioli writes ("[OSSTest PATCH [RFC] 2/4] ts-fedora-install: adde= d for installing fedora guests"): >=20 > > + guest_await_reboot($ho, $gho, 2000); > > + guest_destroy($ho, $gho); > > + > > + # Some fixups > > + store_runvar("$gho->{Guest}_tcpcheckport", 22); >=20 > The Debian guest installation is split into ts-debian-install and > ts-debian-fixup, so that editing the fixup code doesn't involve > rerunning the time-consuming installation step. >=20 > Would that be worth doing here as well ? >=20 Well, given the fact that Debian is installed with xen-tools, there's probably more fixup to do there than here, and that's why it looked sensible enough to keep the two together in this case. Anyway, I think being able to change what we do during fixup without necessarily having to reinstall is something valuable to have. I'll go for it. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-qVcMXY9G03kFuSZL+70J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKrRYsACgkQk4XaBE3IOsRNJgCggm0/3wtMCWJZiiujpG4wZ1fu fEoAn2Y4Nh8pz68R7UINjpyr+iyb4sWD =ZKxF -----END PGP SIGNATURE----- --=-qVcMXY9G03kFuSZL+70J-- --===============4388209017353645377== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4388209017353645377==--