All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <clm@fb.com>
To: "bo.li.liu@oracle.com" <bo.li.liu@oracle.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] Btrfs: avoid building inode cache repeatly
Date: Mon, 16 Dec 2013 15:09:15 +0000	[thread overview]
Message-ID: <1387206565.18897.4.camel@ret.masoncoding.com> (raw)
In-Reply-To: <1387178735-30832-2-git-send-email-bo.li.liu@oracle.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 990 bytes --]

On Mon, 2013-12-16 at 15:25 +0800, Liu Bo wrote:
> Inode cache is similar to free space cache and in fact shares the same
> code, however, we don't load inode cache unless we're about to allocate
> inode id, then there is a case where we only commit the transaction during
> other operations, such as snapshot creation, we now update fs roots' generation
> to the new transaction id, after that when we want to load the inode cache,
> we'll find that it's not valid thanks to the mismatch of generation, and we
> have to push btrfs-ino-cache thread to build inode cache from disk, and
> this operation is sometimes time-costing.
> 
> So to fix the above, we load inode cache into memory during reading fs root.

Please reorder these so the patch that causes problems comes after the
patches that fix the problems ;)  IOW, please make it bisect friendly.

-chris

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±ý»k~ÏâžØ^n‡r¡ö¦zË\x1aëh™¨è­Ú&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿïêÿ‘êçz_è®\x0fæj:+v‰¨þ)ߣøm

  parent reply	other threads:[~2013-12-16 15:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16  7:25 [PATCH v2 0/3] Btrfs: inode cache fixes Liu Bo
2013-12-16  7:25 ` [PATCH v2 1/3] Btrfs: avoid building inode cache repeatly Liu Bo
2013-12-16  9:04   ` Miao Xie
2013-12-16 10:26     ` Liu Bo
2013-12-16 10:54       ` Miao Xie
2013-12-16 15:09   ` Chris Mason [this message]
2013-12-16  7:25 ` [PATCH v2 2/3] Btrfs: don't build inode cache for orphan root Liu Bo
2013-12-16  7:25 ` [PATCH v2 3/3] Btrfs: fix EEXIST error when creating new file in subvolume/snapshot Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387206565.18897.4.camel@ret.masoncoding.com \
    --to=clm@fb.com \
    --cc=bo.li.liu@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.