From: Johannes Berg <johannes@sipsolutions.net>
To: Joe Perches <joe@perches.com>
Cc: Jiri Benc <jbenc@redhat.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] ieee80211_i.h: Align struct ps_data.tim to unsigned long
Date: Thu, 19 Dec 2013 09:19:12 +0100 [thread overview]
Message-ID: <1387441152.4298.5.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1387414337.13593.48.camel@joe-AO722>
On Wed, 2013-12-18 at 16:52 -0800, Joe Perches wrote:
> Its address is used as an unsigned long *, so make sure
> that the tim u8 array is properly aligned.
>
> Signed-off-by: Joe Perches <joe@perches.com
> ---
> > Care to send a proper patch? Otherwise I'll just re-do it and pick it up
> > that way ...
>
> I had a passing thought about this when out today.
> It should really be set to __aligned(__alignof(unsigned long))
> so here's a proper patch.
Hmm, yeah, I guess that's true, though sizeof() is probably >= on
anything where Linux runs (and otherwise arrays get problematic anyway?)
Anyway, I've dropped my patch in favour of yours.
johannes
prev parent reply other threads:[~2013-12-19 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 8:16 ieee80211_i.h: shouldn't struct ps_data.tim be aligned unsigned long? Joe Perches
2013-12-18 9:19 ` Johannes Berg
2013-12-18 9:23 ` Joe Perches
2013-12-19 0:52 ` [PATCH] ieee80211_i.h: Align struct ps_data.tim to unsigned long Joe Perches
2013-12-19 8:19 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387441152.4298.5.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jbenc@redhat.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.