All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Yasir Khan <yasir_khan@mentor.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V3] openssl.inc: Install c_rehash utility with openssl
Date: Thu, 19 Dec 2013 13:33:14 +0000	[thread overview]
Message-ID: <1387459994.6402.69.camel@ted> (raw)
In-Reply-To: <1387268915-28265-1-git-send-email-yasir_khan@mentor.com>

On Tue, 2013-12-17 at 13:28 +0500, Yasir Khan wrote:
> From: mykhani <yasir_khan@mentor.com>
> 
> c_rehash utility is not being installed with openssl.It conveniently
> generates hash and symbolic links based on it for CA certificates
> stored locally for SSL based server authentication
> 
> Signed-off-by: Yasir-Khan <yasir_khan@mentor.com>
> ---
>  meta/recipes-connectivity/openssl/openssl.inc |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Unfortunately this commit has increased our benchmark build time by
approximately 3 minutes on a 1 hour 25 minute build time which is quite
a regression :(.

Would you be able to help figure out how we can regain some of the
performance?

Cheers,

Richard

> diff --git a/meta/recipes-connectivity/openssl/openssl.inc b/meta/recipes-connectivity/openssl/openssl.inc
> index 3bfe569..cdb1809 100644
> --- a/meta/recipes-connectivity/openssl/openssl.inc
> +++ b/meta/recipes-connectivity/openssl/openssl.inc
> @@ -13,6 +13,9 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=f9a8f968107345e0b75aa8c2ecaa7ec8"
>  
>  DEPENDS = "perl-native-runtime"
>  
> +# Adding RDEPENDS for perl scripts
> +RDEPENDS_${PN}-misc +="perl"
> +
>  SRC_URI = "http://www.openssl.org/source/openssl-${PV}.tar.gz \
>            "
>  S = "${WORKDIR}/openssl-${PV}"
> @@ -37,7 +40,7 @@ PACKAGES =+ "libcrypto libssl ${PN}-misc openssl-conf"
>  FILES_libcrypto = "${base_libdir}/libcrypto${SOLIBS}"
>  FILES_libssl = "${libdir}/libssl.so.*"
>  FILES_${PN} =+ " ${libdir}/ssl/*"
> -FILES_${PN}-misc = "${libdir}/ssl/misc"
> +FILES_${PN}-misc = "${libdir}/ssl/misc ${bindir}/c_rehash"
>  FILES_${PN}-dev += "${base_libdir}/libcrypto${SOLIBSDEV}"
>  
>  # Add the openssl.cnf file to the openssl-conf package.  Make the libcrypto
> @@ -157,6 +160,8 @@ do_install () {
>  	sed -i -e '1s,.*,#!${bindir}/env perl,' ${D}${libdir}/ssl/misc/CA.pl
>  
>  	oe_multilib_header openssl/opensslconf.h
> +	# The c_rehash utility isn't installed by the normal installation process.
> +	install -m 0755 ${S}/tools/c_rehash ${D}${bindir}
>  }
>  
>  BBCLASSEXTEND = "native nativesdk"




  reply	other threads:[~2013-12-19 13:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17  8:28 [PATCH V3] openssl.inc: Install c_rehash utility with openssl Yasir Khan
2013-12-19 13:33 ` Richard Purdie [this message]
2013-12-19 14:17 ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387459994.6402.69.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=yasir_khan@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.