From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VvV5p-0001Fe-Si for mharc-grub-devel@gnu.org; Tue, 24 Dec 2013 11:44:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvV5i-0001DG-N2 for grub-devel@gnu.org; Tue, 24 Dec 2013 11:44:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvV5d-0005xl-CX for grub-devel@gnu.org; Tue, 24 Dec 2013 11:44:22 -0500 Received: from mail-lb0-x233.google.com ([2a00:1450:4010:c04::233]:61373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvV5d-0005x2-4W for grub-devel@gnu.org; Tue, 24 Dec 2013 11:44:17 -0500 Received: by mail-lb0-f179.google.com with SMTP id w7so3000879lbi.10 for ; Tue, 24 Dec 2013 08:44:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:date:in-reply-to:references:content-type :mime-version; bh=0bLGrcRQu20xj25ZmSJAeXnMr61P+8Rnvx81VUkMEnY=; b=L123hIu75Z+A5SRR43GYGRve4QRzv3+aCIHrYJuvGDBK/1tQ7eSbSd0IQ+FEEPTIiI MzLj9W+Nd15A1OzXZ40aYo0llkEdf514hEUU3D5yEeHibtl2bfdK6L6YJpHnRutA/COV 4ptIjjUJYwaN9MKpNqFRujOpX0b1tuPw4gbTxOjq0FukBgDwtJI5wiwYhPDzKlsJj72Q 17Lt9ZTqnqJW9TMd10SUL0Cu2hDibGKJE+/roUyy+SM5OL4ov022pL5UWuai1ApEFMVl PiXyNEKjJd6CEQqJR89x8cCV5rX9vGD7FeEAIqAlrHv6tdW9BHOpwE8dDUUgFsJMY/NX 4/pQ== X-Received: by 10.112.171.41 with SMTP id ar9mr76537lbc.74.1387903455417; Tue, 24 Dec 2013 08:44:15 -0800 (PST) Received: from [192.168.1.44] (ppp91-76-134-134.pppoe.mtu-net.ru. [91.76.134.134]) by mx.google.com with ESMTPSA id np10sm14325377lbb.7.2013.12.24.08.44.14 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Tue, 24 Dec 2013 08:44:14 -0800 (PST) Message-ID: <1387903453.918.53.camel@opensuse.site> Subject: Re: [PATCH] Skip Apple ghosts From: Andrey Borzenkov To: grub-devel@gnu.org Date: Tue, 24 Dec 2013 20:44:13 +0400 In-Reply-To: <52B98B9A.5020609@gmail.com> References: <52B98B9A.5020609@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-MK0w1SFS8s8M0YL5V0eF" X-Mailer: Evolution 3.10.2 Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::233 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Dec 2013 16:44:28 -0000 --=-MK0w1SFS8s8M0YL5V0eF Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D0=92 =D0=92=D1=82, 24/12/2013 =D0=B2 14:26 +0100, Vladimir '=CF=86-coder/= phcoder' Serbinenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > Hello, all. It was discovered that on macs sometimes firmware defines > ghost disks with vendor suffix. E.g. > /ACPI(a0341d0,0)/PCI(2,1f)/UnknownMessaging(12)/EndEntire > is a normal disks with partitions presented with HD(...) but then > /ACPI(a0341d0,0)/PCI(2,1f)/UnknownMessaging(12)/MediaVendor(Apple)[0: > ]/EndEntire > is a ghost disk. It has as suffix a vendor path with empty vendor data. Messaging subtype 12 is IPv4 Device Path. I suppose it is related to NetBoot. > This is a problem because when chainloading on such disks GRUB can't > find handle of partition as none is defined. I propose to dkip ghosts > completely. This should be safe as the skip happens only for empty Apple > vendor suffix and if the parent is already a known disk. Hmm ... should not we simply ignore all unknown media types? They can be added on case by case basis I guess. diff --git a/grub-core/disk/efi/efidisk.c b/grub-core/disk/efi/efidisk.c index e04203f..6dfdb0d 100644 --- a/grub-core/disk/efi/efidisk.c +++ b/grub-core/disk/efi/efidisk.c @@ -310,6 +310,7 @@ name_devices (struct grub_efidisk_data *devices) grub_efi_print_device_path (d->device_path); #endif /* For now, ignore the others. */ + d->last_device_path =3D 0; break; } } > Did anyone see anything similar? > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel --=-MK0w1SFS8s8M0YL5V0eF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlK5ud0ACgkQR6LMutpd94y+xQCgkx5yeFrmyEQN4TWsRdxV3SFs yaIAn3hqmQWBYpOzfsdlKQ2iDpnzaLyU =zeOv -----END PGP SIGNATURE----- --=-MK0w1SFS8s8M0YL5V0eF--