From: roy.qing.li@gmail.com
To: netdev@vger.kernel.org
Subject: [PATCH net-next] core: remove old parameter for __dst_destroy_metrics_generic
Date: Fri, 27 Dec 2013 17:26:45 +0800 [thread overview]
Message-ID: <1388136405-25019-1-git-send-email-roy.qing.li@gmail.com> (raw)
From: Li RongQing <roy.qing.li@gmail.com>
when call __dst_destroy_metrics_generic, we always know who old is, so
do not need to pass it.
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
---
include/net/dst.h | 7 +++----
net/core/dst.c | 5 +++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/net/dst.h b/include/net/dst.h
index 77eb53f..7c86f3e 100644
--- a/include/net/dst.h
+++ b/include/net/dst.h
@@ -119,13 +119,12 @@ static inline bool dst_metrics_read_only(const struct dst_entry *dst)
return dst->_metrics & DST_METRICS_READ_ONLY;
}
-void __dst_destroy_metrics_generic(struct dst_entry *dst, unsigned long old);
+void __dst_destroy_metrics_generic(struct dst_entry *dst);
static inline void dst_destroy_metrics_generic(struct dst_entry *dst)
{
- unsigned long val = dst->_metrics;
- if (!(val & DST_METRICS_READ_ONLY))
- __dst_destroy_metrics_generic(dst, val);
+ if (!dst_metrics_read_only(dst))
+ __dst_destroy_metrics_generic(dst);
}
static inline u32 *dst_metrics_write_ptr(struct dst_entry *dst)
diff --git a/net/core/dst.c b/net/core/dst.c
index ca4231e..f1875ee 100644
--- a/net/core/dst.c
+++ b/net/core/dst.c
@@ -308,10 +308,11 @@ u32 *dst_cow_metrics_generic(struct dst_entry *dst, unsigned long old)
EXPORT_SYMBOL(dst_cow_metrics_generic);
/* Caller asserts that dst_metrics_read_only(dst) is false. */
-void __dst_destroy_metrics_generic(struct dst_entry *dst, unsigned long old)
+void __dst_destroy_metrics_generic(struct dst_entry *dst)
{
- unsigned long prev, new;
+ unsigned long prev, new, old;
+ old = dst->_metrics;
new = ((unsigned long) dst_default_metrics) | DST_METRICS_READ_ONLY;
prev = cmpxchg(&dst->_metrics, old, new);
if (prev == old)
--
1.7.10.4
next reply other threads:[~2013-12-27 9:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 9:26 roy.qing.li [this message]
2013-12-27 17:08 ` [PATCH net-next] core: remove old parameter for __dst_destroy_metrics_generic David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388136405-25019-1-git-send-email-roy.qing.li@gmail.com \
--to=roy.qing.li@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.