From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VwmCB-0003FR-Ux for mharc-grub-devel@gnu.org; Sat, 28 Dec 2013 00:12:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwmC1-0003En-9j for grub-devel@gnu.org; Sat, 28 Dec 2013 00:12:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VwmBs-00037q-SF for grub-devel@gnu.org; Sat, 28 Dec 2013 00:12:09 -0500 Received: from mail-lb0-x22a.google.com ([2a00:1450:4010:c04::22a]:54500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwmBs-000376-JF for grub-devel@gnu.org; Sat, 28 Dec 2013 00:12:00 -0500 Received: by mail-lb0-f170.google.com with SMTP id c11so4697795lbj.29 for ; Fri, 27 Dec 2013 21:11:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:date:in-reply-to:references:content-type :mime-version; bh=LTkJmRFLGoyMsD7jaS1C0CTagJdHwWm/w15DARHEf4Y=; b=RjEw4iYdUR9T1CVuXb6NeRc/nI7wfsvmbPik8xZJUL3fbYiJJtrI5tI/w5qFgQNw5J TzX21tK97OpIhC8J9YDD8oEpSBYPJ3JbM887W9F6diO9YjckPLcaTi0asD6mxfPQ3aOp J6rF2yvIS3hkquR1oeEdboxYKeDQyne41OlOtBQzT7ZSaAsRwO0j9mtB5STejepvQPpN E8b/LZ+Sxa/AUW0t6IfvYvdTg9LPZau7aldbWexbsgpIb1aZrw78qKDmzSY8GcinASWZ HYMT8SX4cR8mEMFMjn0OZTeDMd+2Zv1iMhvDy3g9Hecuz/IMqifOcjut9LwqPJJPmfVZ 8GCg== X-Received: by 10.112.172.3 with SMTP id ay3mr20834lbc.95.1388207515772; Fri, 27 Dec 2013 21:11:55 -0800 (PST) Received: from [192.168.1.44] (ppp91-76-134-134.pppoe.mtu-net.ru. [91.76.134.134]) by mx.google.com with ESMTPSA id i8sm22564994lbh.2.2013.12.27.21.11.54 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Fri, 27 Dec 2013 21:11:54 -0800 (PST) Message-ID: <1388207514.918.81.camel@opensuse.site> Subject: Re: error.h missing on mingw (grub-core/kern/emu/misc.c fails to compile) From: Andrey Borzenkov To: grub-devel@gnu.org Date: Sat, 28 Dec 2013 09:11:54 +0400 In-Reply-To: <52BDD629.3010906@gmail.com> References: <1388087687.918.69.camel@opensuse.site> <1388168717.918.74.camel@opensuse.site> <52BDD629.3010906@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-26011ZhN6CyX+Jgtu0ji" X-Mailer: Evolution 3.10.2 Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22a X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Dec 2013 05:12:17 -0000 --=-26011ZhN6CyX+Jgtu0ji Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D0=92 =D0=9F=D1=82, 27/12/2013 =D0=B2 20:34 +0100, Vladimir '=CF=86-coder/= phcoder' Serbinenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On 27.12.2013 19:25, Andrey Borzenkov wrote: > > =D0=92 =D0=A7=D1=82, 26/12/2013 =D0=B2 23:54 +0400, Andrey Borzenkov = =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >> I'm not sure how to fix it. It is pulled in by build-grub-pep2elf and > >> build-grub-pe2elf. Those are build time programs and so use > >> BUILD_CPPFLAGS; adding CPPFLAGS_GNULIB is probably not appropriate. It > >> compiles just fine with error.h commented out. May be something like > >> > >> #if !defined(GRUB_BUILD) || defined(HAVE_ERROR_H) > >> > >=20 > > On the second glance - why is needed at all? Nothing defined > > there is used in misc.c and on Linux it compiles just fine with error.h > > as well. > >=20 > > May be we could simply drop it? > >=20 > Yes. I was going to answer with this. Many of includes are inherited by > copying of include parts. > error.h there can simply be removed done --=-26011ZhN6CyX+Jgtu0ji Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlK+XZoACgkQR6LMutpd94zVWACgsKmYC09gh68s1S3xgPGVns2i NGoAoJIHcf+j8zFRM6LCWKMFnsd7dCpA =CinP -----END PGP SIGNATURE----- --=-26011ZhN6CyX+Jgtu0ji--