Re: [PATCH] xfs/133: add quota name beginning with digits test

[Zirong Lang <zlang@redhat.com>]

----- 原始邮件 -----
> 发件人: "Eric Sandeen" <sandeen@sandeen.net>
> 收件人: "Zorro Lang" <zlang@redhat.com>, fstests@vger.kernel.org
> 抄送: eguan@redhat.com, sandeen@redhat.com
> 发送时间: 星期三, 2015年 12 月 09日 上午 1:21:17
> 主题: Re: [PATCH] xfs/133: add quota name beginning with digits test
> 
> On 12/4/15 10:00 AM, Zorro Lang wrote:
> > There're two bugs on xfsprogs:
> > 1. when a project name beinning with digits, it can't be found
> > by run xfs_quota 'quota -p -v ...' command, but 'report' command
> > can find it.
> > 
> > 2. When user or group names beginning with digits, we can't
> > create 'limit' for them, and can't find them either(likes above).
> > 
> > This case will create user, group and project names which beginning
> > with digits, then create limit for them, and query them.
> > 
> > Signed-off-by: Zorro Lang <zlang@redhat.com>
> > ---
> > 
> > Hi,
> > 
> > This case need a test user, that doesn't like user 'fsqa', fsqa is a
> > common user for xfstests, but this case need a special and temporary
> > user and group. So I create and clean them in this case.
> > 
> > But this's the first time a xfstests case add test user/group by itself,
> > so please help to review, if this's appropriate?
> 
> So, I came to the conclusion, and talking w/ Dave I think he concurs, that it
> would be better to document the need for these users in the README; then,
> just like the "fsgqa" user, your test can check for the existence of i.e.
> a "123456-fsgqa" user, and simply _notrun() if it's not present.  This way
> /etc/passwd stays under the system administrator's control, but it's clear
> why
> the test is skipped if the user doesn't exist.

OK, if I don't need to create and clean the user and group, this case 'll be easier.

Due to project name test is independent test, it doesn't depend on user/group name test,
and they're from different patches of xfsprogs.

So I will make a separate test for project:
1) User/group case will '_notrun' if no appropriate test user.
2) Project case always can be run.

Thanks,
Zorro

>  
> -Eric
> 
>