All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: sw@weilnetz.de, Peter Lieven <pl@kamp.de>, aliguori@amazon.com
Subject: [Qemu-devel] [PATCHv3 5/6] ui/vnc: optimize setting in vnc_dpy_update()
Date: Sun,  5 Jan 2014 19:02:30 +0100	[thread overview]
Message-ID: <1388944951-14767-6-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1388944951-14767-1-git-send-email-pl@kamp.de>

Signed-off-by: Peter Lieven <pl@kamp.de>
---
 ui/vnc.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/ui/vnc.c b/ui/vnc.c
index 980df34..805c47a 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -430,7 +430,6 @@ static int vnc_refresh_server_surface(VncDisplay *vd);
 static void vnc_dpy_update(DisplayChangeListener *dcl,
                            int x, int y, int w, int h)
 {
-    int i;
     VncDisplay *vd = container_of(dcl, VncDisplay, dcl);
     struct VncSurface *s = &vd->guest;
     int width = surface_width(vd->ds);
@@ -451,9 +450,8 @@ static void vnc_dpy_update(DisplayChangeListener *dcl,
     h = MIN(h, height);
 
     for (; y < h; y++) {
-        for (i = 0; i < w; i += VNC_DIRTY_PIXELS_PER_BIT) {
-            set_bit((x + i) / VNC_DIRTY_PIXELS_PER_BIT, s->dirty[y]);
-        }
+        bitmap_set(s->dirty[y], x / VNC_DIRTY_PIXELS_PER_BIT,
+                   w / VNC_DIRTY_PIXELS_PER_BIT);
     }
 }
 
-- 
1.7.9.5

  parent reply	other threads:[~2014-01-05 18:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-05 18:02 [Qemu-devel] [PATCHv3 0/6] ui/vnc: update optimizations Peter Lieven
2014-01-05 18:02 ` [Qemu-devel] [PATCHv3 1/6] ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro Peter Lieven
2014-01-06  6:52   ` Wenchao Xia
2014-01-06  8:02     ` Peter Lieven
2014-01-05 18:02 ` [Qemu-devel] [PATCHv3 2/6] ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT Peter Lieven
2014-01-06  7:03   ` Wenchao Xia
2014-01-05 18:02 ` [Qemu-devel] [PATCHv3 3/6] ui/vnc: optimize dirty bitmap tracking Peter Lieven
2014-01-06 10:08   ` Wenchao Xia
2014-01-06 13:31     ` Peter Lieven
2014-01-07  2:00       ` Wenchao Xia
2014-01-06 17:37     ` Peter Lieven
2014-01-05 18:02 ` [Qemu-devel] [PATCHv3 4/6] ui/vnc: optimize clearing in find_and_clear_dirty_height() Peter Lieven
2014-01-05 18:02 ` Peter Lieven [this message]
2014-01-05 18:02 ` [Qemu-devel] [PATCHv3 6/6] ui/vnc: disable adaptive update calculations if not needed Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388944951-14767-6-git-send-email-pl@kamp.de \
    --to=pl@kamp.de \
    --cc=aliguori@amazon.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.