From: Johannes Berg <johannes@sipsolutions.net>
To: fred.chou.nd@gmail.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: remove redundant flag check
Date: Mon, 06 Jan 2014 16:19:51 +0100 [thread overview]
Message-ID: <1389021591.5891.27.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <52b8191b.6ade440a.6499.ffff91da@mx.google.com> (sfid-20131223_120607_181506_F3036311)
On Mon, 2013-12-23 at 19:07 +0800, fred.chou.nd@gmail.com wrote:
> From: Fred Chou <fred.chou.nd@gmail.com>
>
> It's not necessary to check a flag setting and then
> set it anyway. The outer condition check is redundant
> in the code below. Remove the outer if.
It may be redundant in theory, but I think it makes the code easier to
read, and it avoids all the other checks and the flags write. I don't
think I want to apply this.
johannes
prev parent reply other threads:[~2014-01-06 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 11:07 [PATCH] mac80211: remove redundant flag check fred.chou.nd
2014-01-06 15:19 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389021591.5891.27.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=fred.chou.nd@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.