From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Olof Johansson <olof.johansson@axis.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] bitbake: bb.fetch2.git: Fix _latest_revision function while using tags
Date: Tue, 07 Jan 2014 13:40:55 +0000 [thread overview]
Message-ID: <1389102055.6899.25.camel@ted> (raw)
In-Reply-To: <20140107103602.GP31548@axis.com>
On Tue, 2014-01-07 at 11:36 +0100, Olof Johansson wrote:
> On 14-01-05 02:53 +0100, Andrei Gherzan wrote:
> > When getting the revision we must take into consideration if the name we are
> > looking for is a tag and in that case we need the dereferenced commit ID in
> > order to check for it existance in a specific branch.
> >
> > So first search for the reference^{} commit ID and only if that returns nothing
> > get the name as it is.
>
> I think this is the same issue I've tried to solve in a patch i
> sent in December (subject: bb.fetch2.git: support resolving both
> tags and branches). I haven't heard anything about it yet though.
I put this off as I wanted to spend some time and see if we couldn't
come up with something simpler. Andrei's patch is simpler, the question
is whether it covers all the cases and whether we even need the fallback
code?
I've merged the nobranch code since its clear there are cases when that
is the right thing to do and its a seperate issue to this.
Cheers,
Richard
next prev parent reply other threads:[~2014-01-07 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 1:53 [PATCH] bitbake: bb.fetch2.git: Fix _latest_revision function while using tags Andrei Gherzan
2014-01-07 10:36 ` Olof Johansson
2014-01-07 13:40 ` Richard Purdie [this message]
2014-01-07 14:46 ` Olof Johansson
2014-01-07 15:02 ` Richard Purdie
2014-01-07 15:48 ` Olof Johansson
2014-01-07 17:18 ` Andrei Gherzan
2014-01-07 13:38 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389102055.6899.25.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=olof.johansson@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.