From: Florian Albrechtskirchinger <falbrechtskirchinger@gmail.com>
To: btrfs <linux-btrfs@vger.kernel.org>
Subject: No SysRq remount because sb->s_bdev is NULL
Date: Sat, 28 Jul 2012 15:41:16 +0200 [thread overview]
Message-ID: <1389197.DvrDHJORPI@nezir> (raw)
Hi,
During a SysRq emergency remount Btrfs mounts are not remounted. I tracked the
issue down to this line in do_emergency_remount() in fs/super.c:
if (sb->s_root && sb->s_bdev && (sb->s_flags & MS_BORN) &&
!(sb->s_flags & MS_RDONLY))
s_bdev is NULL for Btrfs super blocks and subsequently do_remount_sb() is
never called. I couldn't think of a solution, besides resorting to an ugly
strcmp(sb->s_type->name, "btrfs"), without adding a field to struct super_block
or similar changes.
Thoughts?
Flo
next reply other threads:[~2012-07-28 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 13:41 Florian Albrechtskirchinger [this message]
2012-07-28 13:46 ` No SysRq remount because sb->s_bdev is NULL Andreas Philipp
2012-07-28 14:50 ` Florian Albrechtskirchinger
2012-07-28 16:30 ` Andreas Philipp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389197.DvrDHJORPI@nezir \
--to=falbrechtskirchinger@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.