From: Paul Bolle <pebolle@tiscali.nl>
To: Matthew Wilcox <matthew@wil.cx>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [SCSI] advansys: change buildtime warning into runtime error
Date: Wed, 08 Jan 2014 21:05:14 +0100 [thread overview]
Message-ID: <1389211514.14754.10.camel@x220> (raw)
In-Reply-To: <1359454842.1345.40.camel@x61.thuisdomein>
On Tue, 2013-01-29 at 11:20 +0100, Paul Bolle wrote:
> On Mon, 2012-11-05 at 11:58 +0100, Paul Bolle wrote:
> > Building advansys.o triggers this warning:
> > drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not properly converted to the DMA API [-Wcpp]
> >
> > This warning can be traced back to a patch called "advansys: add warning
> > and convert #includes" which was included in v2.6.10. That patch also
> > marked the driver as BROKEN.
> >
> > Commit 4661e3eace2c7b8433476b5bf0ee437ab3c7dfd4 ("[SCSI] advansys
> > driver: limp along on x86") enabled this driver for x86-32. And commit
> > 9d511a4b29de6764931343d03e493f2e04df0271 ("[SCSI] advansys: Changes to
> > work on parisc") enabled this driver for all architectures. But the
> > commit explanation stated:
> > I haven't removed the #warning yet because virt_to_bus/bus_to_virt are
> > only eliminated for narrow boards. Wide boards need more work.
> >
> > Five years have passed and, apparently, those wide boards still need
> > more work. So let's change the buildtime warning into a runtime error,
> > only printed for those wide boards. Perhaps that might push the people
> > using those wide boards to convert this driver. And for all others
> > there's now one less buildtime warning to ignore.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > Compile tested only. I don't have any AdvanSys SCSI boards (neither
> > narrow nor wide).
>
> The date of this message suggests I submitted this patch for a warning
> seen while building v3.7-rc4. An identical warning can be seen while
> building v3.8-rc5. What's the status of my patch? Did anyone find some
> time to have a look at it?
I've been carrying this patch locally for over a year. Is there any
chance of someone trying to remove this buildtime warning?
I'm inclined to submit a path to Fedora - my local builds use
their .config as a base - to just disable this driver. It seems that
would increase my chances of finally shutting down this warning.
Paul Bolle
next prev parent reply other threads:[~2014-01-08 20:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 10:58 [PATCH] [SCSI] advansys: change buildtime warning into runtime error Paul Bolle
2013-01-29 10:20 ` Paul Bolle
2014-01-08 20:05 ` Paul Bolle [this message]
2014-01-08 20:15 ` Ondrej Zary
2014-01-08 20:29 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389211514.14754.10.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.