From: Rostislav Lisovy <lisovy@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
pisa@cmp.felk.cvut.cz
Subject: Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver
Date: Thu, 09 Jan 2014 23:55:57 +0100 [thread overview]
Message-ID: <1389308157.5521.5.camel@lolumad> (raw)
In-Reply-To: <20140108074701.GP5443@mwanda>
On Wed, 2014-01-08 at 10:47 +0300, Dan Carpenter wrote:
> On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote:
> > This patch adds Comedi driver for Humusoft MF634 (PCIe) and
> > MF624 (PCI) data acquisition cards. The legacy card Humusoft
> > MF614 is not supported. More info about the cards may be found
> > at http://humusoft.cz/produkty/datacq/
> > The driver was tested with both cards. Everything seems to work
> > properly. Just the basic functionality of the card (DIO, ADC, DAC)
> > is supported by this driver.
> >
> > Signed-off-by: Rostislav Lisovy <lisovy@gmail.com>
> >
> > create mode 100644 drivers/staging/comedi/drivers/mf6x4.c
> >
>
> There should be a "---" after the Signed-off-by line and before the
> diffstat "create mode 100644 drivers/staging/comedi/drivers/mf6x4.c"
> line. Otherwise, the diffstat gets included in the changelog.
I just resent the v3 patch with this flaw corrected. What surprises me a
bit is the fact that the issue was caused by the 'git format-patch'
command called with '--summary' argument. The dashes are included
properly when the argument is not used. Does it make sense?
Regards;
Rostislav Lisovy
next prev parent reply other threads:[~2014-01-09 22:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 22:24 [PATCH v2] comedi: Humusoft MF634 and MF624 DAQ cards driver Rostislav Lisovy
2014-01-07 22:24 ` [PATCH] " Rostislav Lisovy
2014-01-08 7:47 ` Dan Carpenter
2014-01-08 8:35 ` Rostislav Lisovy
2014-01-08 10:42 ` Ian Abbott
2014-01-09 22:55 ` Rostislav Lisovy [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-09 22:46 [PATCH v3] " Rostislav Lisovy
2014-01-09 22:46 ` [PATCH] " Rostislav Lisovy
2014-01-10 10:29 ` Ian Abbott
2013-12-31 1:36 Rostislav Lisovy
2013-12-31 1:36 ` Rostislav Lisovy
2013-12-31 2:31 ` Dan Carpenter
2014-01-02 18:38 ` Hartley Sweeten
2014-01-05 15:04 ` Rostislav Lisovy
2014-01-05 18:18 ` Dan Carpenter
2014-01-06 12:37 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389308157.5521.5.camel@lolumad \
--to=lisovy@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pisa@cmp.felk.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.