From: Harry Mason <harry.mason@smoothwall.net>
To: Jamal Hadi Salim <hadi@mojatatu.com>
Cc: linux-netdev <netdev@vger.kernel.org>
Subject: [PATCH] sch_htb: let skb->priority refer to non-leaf class
Date: Thu, 16 Jan 2014 14:45:19 +0000 [thread overview]
Message-ID: <1389883519.4703.5.camel@azathoth.dev.smoothwall.net> (raw)
If the class in skb->priority is not a leaf, apply filters from the
selected class, not the qdisc. This allows netfilter or user space
to partially classify the packet and tc filters to finish it off.
Signed-off-by: Harry Mason <harry.mason@smoothwall.net>
---
net/sched/sch_htb.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
index 717b210..e50ab65 100644
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c
@@ -223,7 +223,13 @@ static struct htb_class *htb_classify(struct
sk_buff *skb, struct Qdisc *sch,
return cl;
*qerr = NET_XMIT_SUCCESS | __NET_XMIT_BYPASS;
- tcf = q->filter_list;
+
+ /* Start with inner filter chain if a non-leaf class is selected */
+ if (cl)
+ tcf = cl->filter_list;
+ else
+ tcf = q->filter_list;
+
while (tcf && (result = tc_classify(skb, tcf, &res)) >= 0) {
#ifdef CONFIG_NET_CLS_ACT
switch (result) {
--
1.7.10.4
next reply other threads:[~2014-01-16 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 14:45 Harry Mason [this message]
2014-01-16 16:25 ` [PATCH] sch_htb: let skb->priority refer to non-leaf class Eric Dumazet
2014-01-17 10:19 ` [PATCH v2] " Harry Mason
2014-01-17 12:53 ` Sergei Shtylyov
2014-01-17 13:22 ` [PATCH v3] " Harry Mason
2014-01-21 22:36 ` David Miller
2014-01-22 12:41 ` Jamal Hadi Salim
2014-01-22 14:47 ` Eric Dumazet
2014-01-23 1:40 ` David Miller
2014-01-17 14:35 ` [PATCH v2] " Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389883519.4703.5.camel@azathoth.dev.smoothwall.net \
--to=harry.mason@smoothwall.net \
--cc=hadi@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.