From mboxrd@z Thu Jan 1 00:00:00 1970 From: shc_work@mail.ru (=?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?=) Date: Fri, 17 Jan 2014 20:59:43 +0400 Subject: =?UTF-8?B?UmU6IFtQQVRDSCBWMyAzLzNdIHBvd2VyOiByZXNldDogdXNlIHN5c2NvbiBk?= =?UTF-8?B?cml2ZXIgdG8gcGFyc2UgcmVib290IHJlZ2lzdGVyIGZyb20gc2N1?= In-Reply-To: <201401171752.47393.arnd@arndb.de> References: <1389748055-23534-1-git-send-email-fkan@apm.com> <1389748055-23534-4-git-send-email-fkan@apm.com> <201401171752.47393.arnd@arndb.de> Message-ID: <1389977983.940533034@f47.i.mail.ru> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ???????, 17 ?????? 2014, 17:52 +01:00 ?? Arnd Bergmann : > On Wednesday 15 January 2014, Feng Kan wrote: > > +static int __init xgene_reboot_init(void) > > { > > arm_pm_restart = xgene_restart; > > return 0; > > } > > device_initcall(xgene_reboot_init); > > This won't work on a generic kernel, since you unconditionally set the > pm_restart function to your own, which is broken for everything else. > > Please keep the platform_driver to attach to the reboot device > as you had before. It might be good to turn this into a generic > "syscon-reset" driver that gets both the register number and > the contents to write from the device node. I am not sure but think the new driver for SYSCON GPIOs can be reused for such purpose: http://www.spinics.net/lists/devicetree/msg18221.html --- From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= Subject: =?UTF-8?B?UmU6IFtQQVRDSCBWMyAzLzNdIHBvd2VyOiByZXNldDogdXNlIHN5c2NvbiBk?= =?UTF-8?B?cml2ZXIgdG8gcGFyc2UgcmVib290IHJlZ2lzdGVyIGZyb20gc2N1?= Date: Fri, 17 Jan 2014 20:59:43 +0400 Message-ID: <1389977983.940533034@f47.i.mail.ru> References: <1389748055-23534-1-git-send-email-fkan@apm.com> <1389748055-23534-4-git-send-email-fkan@apm.com> <201401171752.47393.arnd@arndb.de> Reply-To: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <201401171752.47393.arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?UTF-8?B?QXJuZCBCZXJnbWFubg==?= Cc: =?UTF-8?B?RmVuZyBLYW4=?= , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org 0J/Rj9GC0L3QuNGG0LAsIDE3INGP0L3QstCw0YDRjyAyMDE0LCAxNzo1MiArMDE6MDAg0L7RgiBB cm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPjoKPiBPbiBXZWRuZXNkYXkgMTUgSmFudWFyeSAy MDE0LCBGZW5nIEthbiB3cm90ZToKPiA+ICtzdGF0aWMgaW50IF9faW5pdCB4Z2VuZV9yZWJvb3Rf aW5pdCh2b2lkKQo+ID4gIHsKPiA+ICAgICAgICAgYXJtX3BtX3Jlc3RhcnQgPSB4Z2VuZV9yZXN0 YXJ0Owo+ID4gICAgICAgICByZXR1cm4gMDsKPiA+ICB9Cj4gPiAgZGV2aWNlX2luaXRjYWxsKHhn ZW5lX3JlYm9vdF9pbml0KTsKPiAKPiBUaGlzIHdvbid0IHdvcmsgb24gYSBnZW5lcmljIGtlcm5l bCwgc2luY2UgeW91IHVuY29uZGl0aW9uYWxseSBzZXQgdGhlCj4gcG1fcmVzdGFydCBmdW5jdGlv biB0byB5b3VyIG93biwgd2hpY2ggaXMgYnJva2VuIGZvciBldmVyeXRoaW5nIGVsc2UuCj4gCj4g UGxlYXNlIGtlZXAgdGhlIHBsYXRmb3JtX2RyaXZlciB0byBhdHRhY2ggdG8gdGhlIHJlYm9vdCBk ZXZpY2UKPiBhcyB5b3UgaGFkIGJlZm9yZS4gSXQgbWlnaHQgYmUgZ29vZCB0byB0dXJuIHRoaXMg aW50byBhIGdlbmVyaWMKPiAic3lzY29uLXJlc2V0IiBkcml2ZXIgdGhhdCBnZXRzIGJvdGggdGhl IHJlZ2lzdGVyIG51bWJlciBhbmQKPiB0aGUgY29udGVudHMgdG8gd3JpdGUgZnJvbSB0aGUgZGV2 aWNlIG5vZGUuCgpJIGFtIG5vdCBzdXJlIGJ1dCB0aGluayB0aGUgbmV3IGRyaXZlciBmb3IgU1lT Q09OIEdQSU9zIGNhbiBiZQpyZXVzZWQgZm9yIHN1Y2ggcHVycG9zZToKaHR0cDovL3d3dy5zcGlu aWNzLm5ldC9saXN0cy9kZXZpY2V0cmVlL21zZzE4MjIxLmh0bWwKCi0tLQpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752813AbaAQRAX (ORCPT ); Fri, 17 Jan 2014 12:00:23 -0500 Received: from fallback8.mail.ru ([94.100.176.136]:48642 "EHLO fallback8.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbaAQRAV (ORCPT ); Fri, 17 Jan 2014 12:00:21 -0500 From: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= To: =?UTF-8?B?QXJuZCBCZXJnbWFubg==?= Cc: linux-arm-kernel@lists.infradead.org, =?UTF-8?B?RmVuZyBLYW4=?= , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: =?UTF-8?B?UmU6IFtQQVRDSCBWMyAzLzNdIHBvd2VyOiByZXNldDogdXNlIHN5c2NvbiBk?= =?UTF-8?B?cml2ZXIgdG8gcGFyc2UgcmVib290IHJlZ2lzdGVyIGZyb20gc2N1?= Mime-Version: 1.0 X-Mailer: Mail.Ru Mailer 1.0 X-Originating-IP: [188.134.40.128] Date: Fri, 17 Jan 2014 20:59:43 +0400 Reply-To: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= X-Priority: 3 (Normal) Message-ID: <1389977983.940533034@f47.i.mail.ru> Content-Type: text/plain; charset=utf-8 X-Mras: Ok X-Spam: undefined In-Reply-To: <201401171752.47393.arnd@arndb.de> References: <1389748055-23534-1-git-send-email-fkan@apm.com> <1389748055-23534-4-git-send-email-fkan@apm.com> <201401171752.47393.arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s0HH0RRR026231 Пятница, 17 января 2014, 17:52 +01:00 от Arnd Bergmann : > On Wednesday 15 January 2014, Feng Kan wrote: > > +static int __init xgene_reboot_init(void) > > { > > arm_pm_restart = xgene_restart; > > return 0; > > } > > device_initcall(xgene_reboot_init); > > This won't work on a generic kernel, since you unconditionally set the > pm_restart function to your own, which is broken for everything else. > > Please keep the platform_driver to attach to the reboot device > as you had before. It might be good to turn this into a generic > "syscon-reset" driver that gets both the register number and > the contents to write from the device node. I am not sure but think the new driver for SYSCON GPIOs can be reused for such purpose: http://www.spinics.net/lists/devicetree/msg18221.html --- {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I