All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alon Levy <alevy@redhat.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 2/2] qxl: clear irq on reset
Date: Mon, 20 Jan 2014 12:44:19 +0200	[thread overview]
Message-ID: <1390214659-12296-2-git-send-email-alevy@redhat.com> (raw)
In-Reply-To: <1390214659-12296-1-git-send-email-alevy@redhat.com>

Without this we occasionally trigger an assert at
hw/pci/pci.c:pcibus_reset that asserts the irq_count is zero on reset.

This has become a problem with the new drm driver for linux, since doing
a reboot from console causes a race between console updates that set the
irq and the reset assertion that the irq is clear.

Signed-off-by: Alon Levy <alevy@redhat.com>
---
 hw/display/qxl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index f6af470..e164d96 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -1126,6 +1126,7 @@ static void qxl_reset_state(PCIQXLDevice *d)
     d->num_free_res = 0;
     d->last_release = NULL;
     memset(&d->ssd.dirty, 0, sizeof(d->ssd.dirty));
+    qxl_update_irq(d);
 }
 
 static void qxl_soft_reset(PCIQXLDevice *d)
-- 
1.8.4.2

  reply	other threads:[~2014-01-20 10:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20 10:44 [Qemu-devel] [PATCH 1/2] hw/display/qxl: improve framebuffer error message Alon Levy
2014-01-20 10:44 ` Alon Levy [this message]
2014-01-21 10:56   ` [Qemu-devel] [PATCH 2/2] qxl: clear irq on reset Gerd Hoffmann
2014-01-20 11:55 ` [Qemu-devel] [PATCH 1/2] hw/display/qxl: improve framebuffer error message Markus Armbruster
2014-01-20 13:29   ` [Qemu-devel] [PATCH v2] hw/display/qxl: fix signed to unsigned comparison Alon Levy
2014-01-20 13:52     ` Markus Armbruster
2014-01-20 13:53     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390214659-12296-2-git-send-email-alevy@redhat.com \
    --to=alevy@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.