From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
Karl Beldan <karl.beldan@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Karl Beldan <karl.beldan@rivierawaves.com>
Subject: Re: [PATCH] mac80211: send {add,del}ba on AC_VO like other mgmt frames, as per spec
Date: Thu, 23 Jan 2014 15:08:26 +0100 [thread overview]
Message-ID: <1390486106.4142.15.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAGXE3d_VJ=QPTv4f6LfKror3H0dyQsVio5urkbVKUyKmZSoDYQ@mail.gmail.com> (sfid-20140123_144235_758501_6ED93285)
On Thu, 2014-01-23 at 14:42 +0100, Helmut Schaa wrote:
> On Thu, Jan 23, 2014 at 7:08 AM, Grumbach, Emmanuel
> <emmanuel.grumbach@intel.com> wrote:
> >> >> So, I guess you are taking what I sent ?
> >> >
> >> >Haven't really made up my mind yet ... I think it's more correct, so I
> >> >should, but I also don't really want to break the ralink drivers over
> >> >what seems to me to be a fairly small issue.
> >>
> >> I think I'm fine with this now. Let's just see if someone experiences any
> >> issues ...
> >>
> >> Furthermore I think i even remember that you can force ralink HW to stop a
> >> BA session. But all in all lets better comply with the spec ...
> >
> > Well - you need to see what "stop a BA session" mean. If you are able to tell the HW no AMPDUs anymore *now*, then ok - but you still have the out-of-order TX problem. Unless you use the same TX queue for AMPUs and non-AMPDUs and don't fear reordering issues
>
> We shouldn't have reordering issues in rt2x00 since AMPDUs and MPDUs
> go through the same hw queue.
> However, at the moment the hw will keep on sending AMPDUs that are in
> the TX queue even after we received a DELBA.
> But this is an issue with the ralink drivers ...
Ok.
Karl, can you rewrite the commit log, maybe referencing the original
commit and this discussion (I'd suggest using
http://mid.gmane.org/1390391564-18481-1-git-send-email-karl.beldan@gmail.com) please? Then I'll apply that.
Thanks,
johannes
next prev parent reply other threads:[~2014-01-23 14:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 11:52 [PATCH] mac80211: send {add,del}ba on AC_VO like other mgmt frames, as per spec Karl Beldan
2014-01-22 12:34 ` Johannes Berg
2014-01-22 13:09 ` Karl Beldan
2014-01-22 13:33 ` Helmut Schaa
2014-01-22 15:28 ` Karl Beldan
2014-01-22 15:36 ` Helmut Schaa
2014-01-22 16:41 ` Karl Beldan
2014-01-22 18:51 ` Johannes Berg
2014-01-22 19:16 ` Karl Beldan
2014-01-22 19:21 ` Johannes Berg
2014-01-22 20:47 ` Helmut Schaa
2014-01-23 6:08 ` Grumbach, Emmanuel
2014-01-23 13:42 ` Helmut Schaa
2014-01-23 14:08 ` Johannes Berg [this message]
2014-01-23 19:06 ` [PATCH v2] mac80211: send {ADD,DEL}BA " Karl Beldan
2014-01-23 19:15 ` Johannes Berg
2014-01-23 19:38 ` Karl Beldan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390486106.4142.15.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=emmanuel.grumbach@intel.com \
--cc=helmut.schaa@googlemail.com \
--cc=karl.beldan@gmail.com \
--cc=karl.beldan@rivierawaves.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.