From: Ben Widawsky <benjamin.widawsky@intel.com>
To: Internal GFX Development <gfx-internal-devel@linux.intel.com>,
Intel GFX <intel-gfx@lists.freedesktop.org>
Cc: Ben Widawsky <ben@bwidawsk.net>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: [PATCH 1/5] drm/i915: Round up object allocations
Date: Thu, 23 Jan 2014 19:21:10 -0800 [thread overview]
Message-ID: <1390533674-18402-2-git-send-email-benjamin.widawsky@intel.com> (raw)
In-Reply-To: <1390533674-18402-1-git-send-email-benjamin.widawsky@intel.com>
DRM gets very mad when you request an object which occupies a partial
page. As a DRM driver, i915 never really wants to anger DRM, and would
always just want the rounding done for us.
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
---
drivers/gpu/drm/i915/i915_gem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 024e454..8cd1134 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -4168,6 +4168,8 @@ struct drm_i915_gem_object *i915_gem_alloc_object(struct drm_device *dev,
struct address_space *mapping;
gfp_t mask;
+ size = round_up(size, PAGE_SIZE);
+
obj = i915_gem_object_alloc(dev);
if (obj == NULL)
return NULL;
--
1.8.5.3
next parent reply other threads:[~2014-01-24 3:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1390533674-18402-1-git-send-email-benjamin.widawsky@intel.com>
2014-01-24 3:21 ` Ben Widawsky [this message]
2014-01-25 20:28 ` [PATCH 1/5] drm/i915: Round up object allocations Daniel Vetter
2014-01-26 5:49 ` Ben Widawsky
2014-01-26 9:17 ` Daniel Vetter
2014-01-26 9:57 ` Chris Wilson
2014-01-26 10:01 ` Daniel Vetter
2014-01-26 10:07 ` Chris Wilson
2014-01-26 19:00 ` Ben Widawsky
2014-01-26 19:59 ` Daniel Vetter
2014-01-26 20:03 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390533674-18402-2-git-send-email-benjamin.widawsky@intel.com \
--to=benjamin.widawsky@intel.com \
--cc=ben@bwidawsk.net \
--cc=gfx-internal-devel@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.