Re: [PATCH 1/1] e2fsprogs/populate-extfs.sh: fix a problem on dash

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2014-01-20 at 20:24 +0800, Robert Yang wrote:
> The dash can't handle the or [[ in parameter expansion, for example:
> 
> A=/usr/bin/[[
> B=[[
> C="${A%$B}"
> 
> The C should be "/usr/bin" in common, but it will be /usr/bin/[[ on
> dash, use dirname to fix it.
> 
> NOTE:
> There are 3 lines about parameter expansion, only fix the
> DIR="${DIR%$TGT}" since the other 2 works will and are very useful in
> this case.
> 
> [YOCTO #5712]
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/recipes-devtools/e2fsprogs/e2fsprogs/populate-extfs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I'm afraid I had to revert this as it caused other build failures:

http://autobuilder.yoctoproject.org/main/builders/build-appliance/builds/18/steps/BuildImages_1/logs/stdio

Can you look into why that happened and resent the patch please?

Cheers,

Richard

> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs/populate-extfs.sh b/meta/recipes-devtools/e2fsprogs/e2fsprogs/populate-extfs.sh
> index 7de720b..9b55a4b 100644
> --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs/populate-extfs.sh
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs/populate-extfs.sh
> @@ -23,7 +23,7 @@ DEBUGFS="debugfs"
>  	find $SRCDIR | while read FILE; do
>                  TGT="${FILE##*/}"
>                  DIR="${FILE#$SRCDIR}"
> -                DIR="${DIR%$TGT}"
> +                DIR="$(dirname $DIR)"
>  
>  		# Skip the root dir
>  		[ ! -z "$DIR" ] || continue