From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH V2] quilt: add ac_cv_path_BASH to CACHED_CONFIGUREVARS also for native
Date: Tue, 28 Jan 2014 12:30:28 +0000 [thread overview]
Message-ID: <1390912228.24655.0.camel@ted> (raw)
In-Reply-To: <CAP9ODKp4T5ouY1y8GqnRVFy1SdA9BajmDxOjMkGR0gFzteGuSQ@mail.gmail.com>
On Thu, 2014-01-23 at 09:29 -0200, Otavio Salvador wrote:
> On Thu, Jan 23, 2014 at 5:22 AM, Ming Liu <ming.liu@windriver.com> wrote:
> > On 01/23/2014 03:14 PM, Phil Blundell wrote:
> >>
> >> On Thu, 2014-01-23 at 14:45 +0800, Ming Liu wrote:
> >>>
> >>> +CACHED_CONFIGUREVARS += "ac_cv_path_BASH=/bin/bash"
> >>> -CACHED_CONFIGUREVARS += "ac_cv_path_BASH=${base_bindir}/bash"
> >>
> >> Why did you change this from ${base_bindir} to a hardcoded path?
> >
> > Because base_bindir would be expanded as '${base_prefix}/bin' for native
> > recipe, then it has to set DEPENDS on bash-native which I think is not what
> > it supposed to be, the change would let it locate bash from host
> > environment.
>
> I don't think so.
>
> % git grep base_prefix meta/conf/bitbake.conf
> meta/conf/bitbake.conf:export base_prefix = ""
> meta/conf/bitbake.conf:export base_bindir = "${base_prefix}/bin"
Consider what native.bbclass does to this though. I suspect Ming is
correct here...
Cheers,
Richard
prev parent reply other threads:[~2014-01-28 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 6:45 [PATCH V2] quilt: add ac_cv_path_BASH to CACHED_CONFIGUREVARS also for native Ming Liu
2014-01-23 7:14 ` Phil Blundell
2014-01-23 7:22 ` Ming Liu
2014-01-23 11:29 ` Otavio Salvador
2014-01-28 12:30 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390912228.24655.0.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.