From: Matthew Garrett <matthew.garrett@nebula.com>
To: "mario_limonciello@dell.com" <mario_limonciello@dell.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH 0/1] Add new driver for AlienFX control
Date: Wed, 5 Feb 2014 17:57:11 +0000 [thread overview]
Message-ID: <1391623031.1248.2.camel@x230> (raw)
In-Reply-To: <52F267FA.8020001@dell.com>
On Wed, 2014-02-05 at 10:34 -0600, Mario Limonciello wrote:
> On 02/05/2014 10:24 AM, Matthew Garrett wrote:
> > On Wed, 2014-02-05 at 10:22 -0600, Mario Limonciello wrote:
> >
> >> After digging further in, there actually is control for setting up the LEDs to
> >> perform different tasks in S0 and S3 power states which becomes more difficult
> >> to represent in the LED class. So instead I've created a series of sysfs nodes
> >> to represent the different colors in the different zones.
> > Have you discussed the best way to represent this with the LED class
> > maintainer?
> No I haven't yet. I initially coded it using the LED class, but I kept finding more details for it that didn't seem to match what the LED class provided properly.
>
> The LED class is intended to represent the "brightness" of an individual LED.
Sure, that's the current state. But it makes sense to work on extending
an existing class rather than implementing a custom interface.
--
Matthew Garrett <matthew.garrett@nebula.com>
prev parent reply other threads:[~2014-02-05 17:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 16:22 [PATCH 0/1] Add new driver for AlienFX control Mario Limonciello
2014-02-05 16:22 ` [PATCH 1/1] Add WMI driver for controlling AlienFX on Alienware Mario Limonciello
2014-02-05 16:24 ` [PATCH 0/1] Add new driver for AlienFX control Matthew Garrett
2014-02-05 16:34 ` Mario Limonciello
2014-02-05 17:57 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391623031.1248.2.camel@x230 \
--to=matthew.garrett@nebula.com \
--cc=mario_limonciello@dell.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.