All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] si4713: Remove "select SI4713"
Date: Sun, 09 Feb 2014 16:27:04 +0100	[thread overview]
Message-ID: <1391959624.25424.29.camel@x220> (raw)
In-Reply-To: <52F79C37.5030000@xs4all.nl>

Hans,

On Sun, 2014-02-09 at 16:18 +0100, Hans Verkuil wrote:
> USB_SI4713 and PLATFORM_SI4713 both depend on I2C_SI4713. So the select
> should be I2C_SI4713.

Are you sure? I've actually scanned si4713.c before submitting this
patch and I couldn't find anything in it that these other two modules
require. Have I overlooked anything?

>  If you can post a patch fixing that, then I'll pick
> it up for 3.14.
> 
> With the addition of the USB si4713 driver things moved around and were
> renamed, and these selects were missed.

Thanks,


Paul Bolle


  reply	other threads:[~2014-02-09 15:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-09 14:56 [PATCH] [media] si4713: Remove "select SI4713" Paul Bolle
2014-02-09 15:18 ` Hans Verkuil
2014-02-09 15:27   ` Paul Bolle [this message]
2014-02-09 17:04     ` Hans Verkuil
2014-02-09 17:37       ` Paul Bolle
2014-02-09 17:45         ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391959624.25424.29.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.